Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): refactor to static website deployment & workflow changes #6036

Merged
merged 3 commits into from
May 19, 2023

Conversation

levivannoort
Copy link
Member

@levivannoort levivannoort commented May 17, 2023

Resolves https://github.com/amplication/amplication-infrastructure-next/issues/50

Addition to: #5975

PR Details

Adds support for building and publishing a static website - in this case for the client-component. This also incorporates reworking the affected setup by standardizing the naming convention of deploy & `package.

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@levivannoort levivannoort requested a review from overbit May 17, 2023 16:35
@levivannoort levivannoort self-assigned this May 17, 2023
@nx-cloud
Copy link

nx-cloud bot commented May 17, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 64dd8b4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

Base automatically changed from feat/add-client-support-for-staticwebsite-deployment to next May 19, 2023 10:47
@levivannoort levivannoort requested a review from overbit May 19, 2023 12:14
@overbit overbit merged commit a9f21bd into next May 19, 2023
8 checks passed
@overbit overbit deleted the feat/static-website-deployment-workflow-adaptation branch May 19, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants