-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): add support for static website deployment #5975
feat(client): add support for static website deployment #5975
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f7d8bdf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
I'm in the midst of adding the ci/cd part for this to this pull request. If it can be detached separately, let me know @overbit |
Sure thing |
As talked about before I would still be up for keeping the Dockfiler for the client even though it isn't used in production when moving of to the cdn. |
Added the ci/cd part as a pr to this branch, so should auto update to be merged to next when this is merged. |
1938d8c
to
f7d8bdf
Compare
Fixes : https://github.com/amplication/amplication-infrastructure-next/issues/50
PR Details
Replace the injectEnvVariables.js with nx build configurations to build the client application with the correct variables per environment.
The injectEnvVariables related scripts, nx target
docker:build
and Dockerfile will be deleted as soon as we complete the migration to the new static website setup.PR Checklist
npm test
doesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.