Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add support for static website deployment #5975

Merged
merged 3 commits into from
May 19, 2023

Conversation

overbit
Copy link
Contributor

@overbit overbit commented May 12, 2023

Fixes : https://github.com/amplication/amplication-infrastructure-next/issues/50

PR Details

Replace the injectEnvVariables.js with nx build configurations to build the client application with the correct variables per environment.
The injectEnvVariables related scripts, nx target docker:build and Dockerfile will be deleted as soon as we complete the migration to the new static website setup.

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@nx-cloud
Copy link

nx-cloud bot commented May 12, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f7d8bdf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@overbit overbit marked this pull request as ready for review May 15, 2023 14:27
@levivannoort
Copy link
Member

I'm in the midst of adding the ci/cd part for this to this pull request. If it can be detached separately, let me know @overbit

@overbit
Copy link
Contributor Author

overbit commented May 15, 2023

Sure thing

@EugeneTseitlin EugeneTseitlin self-assigned this May 16, 2023
@levivannoort
Copy link
Member

As talked about before I would still be up for keeping the Dockfiler for the client even though it isn't used in production when moving of to the cdn.

@levivannoort
Copy link
Member

Added the ci/cd part as a pr to this branch, so should auto update to be merged to next when this is merged.

@overbit overbit force-pushed the feat/add-client-support-for-staticwebsite-deployment branch from 1938d8c to f7d8bdf Compare May 19, 2023 10:42
@overbit overbit merged commit 741cb2f into next May 19, 2023
8 checks passed
@overbit overbit deleted the feat/add-client-support-for-staticwebsite-deployment branch May 19, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants