Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): split deployment template file #6058

Merged
merged 2 commits into from
May 19, 2023

Conversation

levivannoort
Copy link
Member

@levivannoort levivannoort commented May 19, 2023

Resolves : https://github.com/amplication/amplication-infrastructure-next/issues/50

Addition to: #5975

PR Details

Splits the workflow file deployment.template.yml into deployment.static.template.yml and deployment.container.template.yml.

🤖 Generated by Copilot at a27ea23

Summary

🚀🔄📦

This pull request refactors the deployment workflows for container and static applications using Nx Cloud. It adds a new workflow for container deployments, updates the existing workflows for static deployments and releases, and configures the inputs and outputs for the amplication-client project.

Oh we're the devops crew and we know what to do
We deploy our apps with kubectl and nx
We use workflows and templates to make our lives easy
And we push our code to the cloud on the count of three

Walkthrough

  • Split the deployment.template.yml workflow into two separate workflows for container and static deployments: deployment.container.template.yml and deployment.static.template.yml (link, link)
  • Rename the deployment.template.yml workflow to deployment.static.template.yml and remove the steps for deploying containerized applications (link, link)
  • Add a secret input for the NX_CLOUD_ACCESS_TOKEN to the deployment.static.template.yml workflow to authenticate with the Nx Cloud service (link)
  • Replace the secrets with vars for the CLOUDFRONT_DISTRIBUTION_ID in the deployment.static.template.yml workflow to use the configuration variable from the vars.yml file (link)
  • Modify the deployment.production.yml and release.template.yml workflows to use the deployment.container.template.yml and deployment.static.template.yml workflows instead of the deployment.template.yml workflow for deploying container and static applications (link, link, link)
  • Add a secret input for the NX_CLOUD_ACCESS_TOKEN to the release.template.yml workflow to authenticate with the Nx Cloud service (link)
  • Add inputs and outputs to the amplication-client project in the project.json file to specify the dependencies and artifacts for the nx commands (link)

@nx-cloud
Copy link

nx-cloud bot commented May 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a27ea23. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@overbit overbit self-requested a review May 19, 2023 13:19
@overbit overbit merged commit 7d17014 into next May 19, 2023
9 checks passed
@overbit overbit deleted the task/split-deployment-template-file branch May 19, 2023 13:24
@levivannoort levivannoort restored the task/split-deployment-template-file branch May 19, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants