Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Entity and Entity Field custom attributes - Epic #6068

Merged
merged 26 commits into from
May 23, 2023

Conversation

yuval-hazaz
Copy link
Member

@yuval-hazaz yuval-hazaz commented May 20, 2023

close: #5990 #5989

PR Details

πŸ€– Generated by Copilot at 2ef0f28

Summary

πŸš€πŸŽ¨πŸ·οΈ

This pull request introduces several improvements and features related to the packaging and deployment of projects as containers or static websites using nx. It also adds support for custom attributes in entities and entity fields, and a contact us link for enterprise users in the limitation notification component. It also removes some unused code and variables, and updates the documentation and naming conventions.

nx targets change
packaging and deploying
autumn of refactor

Walkthrough

  • Rename docker:build target to package:container and deploy target to deploy:container in project.json files and nx.json file to match the new naming convention for packaging and deploying projects as containers (link, link, link, link, link, link)
  • Add new target deploy:static in project.json file for deploying projects as static websites to s3 buckets and invalidating cloudfront distributions using nx run-commands executor (link)
  • Add new reusable template file deployment.static.template.yml for deploying projects as static websites using the nx target deploy:static and aws-actions/configure-aws-credentials action (link)
  • Update ci.yml file to use the new nx outputs for the affected projects that need to be packaged or deployed as containers or static websites and capitalize the nx cloud access token secret (link)
  • Update deployment.container.template.yml file to add a new input parameter for the deployment type and a conditional statement for the deployment job based on the parameter (link, link, link, link, link)
  • Update deployment.production.yml file to use the new nx outputs and targets for the affected projects that need to be packaged or deployed as containers or static websites and the new reusable templates for deploying projects as containers or static (link, link, link, link, link)
  • Update nx.template.yml file and README.md file to use the new nx outputs and targets for the affected projects that need to be packaged or deployed as containers or static websites (link, link, link, link, link, link)
  • Update release.template.yml file and README.md file to use the new nx inputs and targets for the affected projects that need to be packaged or deployed as containers or static websites and capitalize the nx cloud access token secret (link, link, link, link, link)
  • Update client project.json file to add the package.json file as an input for the version target and add new configurations for the build target for different environments using file replacements (link, link)
  • Update client .env file to remove unused variables and add a new variable for the billing feature (link)
  • Update client models.ts file to rename the isPrivate field to isPublic and add the customAttributes field in various types to match the backend schema change (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Update client entity components to include the customAttributes field in the queries and mutations and remove unused imports and calls to trackEvent (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Update client limitation notification component to add a new component for the contact us link for enterprise users using the useCallback hook and a new class name (link, link, link, link, link)

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@yuval-hazaz yuval-hazaz changed the title Feat/entity custom attributes umbrella feat: Entity and Entity Field custom attributes - Epic May 20, 2023
@yuval-hazaz yuval-hazaz changed the base branch from master to next May 20, 2023 19:50
@yuval-hazaz yuval-hazaz marked this pull request as draft May 20, 2023 19:50
@nx-cloud
Copy link

nx-cloud bot commented May 20, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f5a003e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this branch


βœ… Successfully ran 5 targets

Sent with πŸ’Œ from NxCloud.

@abrl91 abrl91 marked this pull request as ready for review May 23, 2023 12:45
@abrl91 abrl91 self-requested a review May 23, 2023 12:46
@abrl91 abrl91 merged commit 8ef1fb0 into next May 23, 2023
10 checks passed
@abrl91 abrl91 deleted the feat/entity-custom-attributes-umbrella branch May 23, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As User - I want to set custom attributes on the entity field level
3 participants