Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add package name to the Android manifest #167

Closed
wants to merge 1 commit into from
Closed

Fix: Add package name to the Android manifest #167

wants to merge 1 commit into from

Conversation

ejain
Copy link

@ejain ejain commented Jul 10, 2023

Getting this error when running pod update after upgrading from 2.17.0 to 2.17.2:

error Failed to build the app: No package name found. Found errors in /Users/xxx/node_modules/@amplitude/react-native/android/src/main/AndroidManifest.xml.

[!] Invalid `Podfile` file: unexpected token at 'info Run CLI with --verbose flag for more details.
'.

 #  from /Users/xxx/ios/Podfile:8
 #  -------------------------------------------
 #  target 'MyApp' do
 >    config = use_native_modules!
 #  
 #  -------------------------------------------

Our Podfile is identical to this one.

The error goes away when we downgrade back to 2.17.0 -- or if we add a package name to Amplitude-ReactNative's manifest.

@deivyrene
Copy link

The issue was introduced here

@gilluminate
Copy link

The issue was introduced here

Does this PR make it backwards compatible then, or will it pose the same problems for people on React Native 0.72?

@ejain
Copy link
Author

ejain commented Jul 11, 2023

I guess the choice is between a build warning for anyone using React Native 0.72, and a build failure for anyone using an earlier version?

@ejain
Copy link
Author

ejain commented Jul 13, 2023

Closing, looks like Amplitude-ReactNative won't be supporting React Native 0.70 going forward: Amplitude-Developer-Docs/amplitude-dev-center#856

@ejain ejain closed this Jul 13, 2023
@ejain ejain deleted the fix-android-manifest branch July 13, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants