Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests on iOS 17 #136

Merged
merged 1 commit into from Mar 15, 2024
Merged

fix: tests on iOS 17 #136

merged 1 commit into from Mar 15, 2024

Conversation

crleona
Copy link
Collaborator

@crleona crleona commented Mar 14, 2024 •
edited

Summary

This updated CI to run on the latest versions of MacOS/Xcode.

Running the tests locally with the latest Xcode results in a few failures, so I've fixed the following:

  • Use sorted key output for JSON, as iOS 17+ uses a more secure dictionary type that randomizes key order
  • Use strict URL parsing as the URL(string:) default behavior has changed in iOS 17
  • Clean up testFilterAndEnrichmentPlugin results so that events aren't duplicated between runs (this does not appear to be an issue on CI, only while running locally). (@yuhao900914, can this test just use an in-memory store instead?)

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@crleona crleona force-pushed the ios-17-test-fixes branch 3 times, most recently from 42e31cd to 91397de Compare March 14, 2024 23:58
@yuhao900914
Copy link
Collaborator

Can this test just use an in-memory store instead?
Yes, which memory it's using doesn't matter.

@crleona crleona force-pushed the ios-17-test-fixes branch 2 times, most recently from 94fec61 to 7f22dd6 Compare March 15, 2024 00:30
justin-fiedler
justin-fiedler approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@crleona crleona merged commit 04e5d03 into main Mar 15, 2024
3 checks passed
@crleona crleona deleted the ios-17-test-fixes branch March 15, 2024 16:59
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@amplitude-sdk-bot
chore(release): 1.4.0 [skip ci]
5d214c4 
# [1.4.0](v1.3.6...v1.4.0) (2024-03-15)

### Bug Fixes

* Don't use idfv as deviceID if disabled. ([#133](#133)) ([76ef012](76ef012))
* Fixes for automatic screen tracking ([#137](#137)) ([55b2ca9](55b2ca9))
* tests on iOS 17 ([#136](#136)) ([04e5d03](04e5d03))

### Features

* migrate storage to for better thread safety ([#129](#129)) ([2bbe919](2bbe919))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@richardpiazza richardpiazza mentioned this pull request Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@izaaz izaaz Awaiting requested review from izaaz

@yuhao900914 yuhao900914 Awaiting requested review from yuhao900914

@Mercy811 Mercy811 Awaiting requested review from Mercy811

@qingzhuozhen qingzhuozhen Awaiting requested review from qingzhuozhen

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crleona @yuhao900914 @justin-fiedler