Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

Create an example that shows all AMP video types in both an amp-carousel and an amp-according #42

Closed
adewale opened this issue Mar 2, 2016 · 2 comments
Closed

Create an example that shows all AMP video types in both an amp-carousel and an amp-according #42

adewale opened this issue Mar 2, 2016 · 2 comments
Assignees
@kul3r4

Comments

@adewale
Copy link

adewale commented Mar 2, 2016

Use the list of AMP video types in #41 to build one example that shows both the carousel and the accordion on the same page. This will allow people to easily compare and contrast the UX of both components.
@kul3r4 kul3r4 self-assigned this Mar 15, 2016
kul3r4 added a commit that referenced this issue Mar 15, 2016
@kul3r4
Fixes #42
9e46a5e
kul3r4 added a commit that referenced this issue Mar 15, 2016
@kul3r4
Fixes #42
dd592d5
kul3r4 added a commit that referenced this issue Mar 16, 2016
@kul3r4
An example which uses different amp video components inside a carouse…
17c6d9e 
…l and an accordion. Fixes #42
kul3r4 added a commit that referenced this issue Mar 17, 2016
@kul3r4
An example which uses different amp video components inside a carouse…
934a1ab 
…l and an accordion. Fixes #42
kul3r4 added a commit that referenced this issue Mar 21, 2016
@kul3r4
An example which uses different amp video components inside a carouse…
e0eb3d7 
…l and an accordion. Fixes #42
@kul3r4
Copy link
Collaborator

kul3r4 commented Mar 21, 2016

@adewale still trying to develop this example.
I am having problems displaying correctly amp-facebook and amp-instagram inside amp-carousel, bugs below:
ampproject/amphtml#2661
ampproject/amphtml#2662

@adewale
Copy link
Author

adewale commented Mar 22, 2016

Thanks for the update and for filing the bugs.

On Monday, 21 March 2016, Chiara Chiappini notifications@github.com wrote:

@adewale https://github.com/adewale still trying to develop this
example.
I am having problems displaying correctly amp-facebook and amp-instagram
inside amp-carousel, bugs below:
ampproject/amphtml#2661
ampproject/amphtml#2661
ampproject/amphtml#2662
ampproject/amphtml#2662

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#42 (comment)

kul3r4 added a commit that referenced this issue Mar 22, 2016
@kul3r4
An example which uses different amp video components inside a carouse…
8606562 
…l and an accordion. Fixes #42
kul3r4 added a commit that referenced this issue Mar 23, 2016
@kul3r4
An example which uses different amp video components inside a carouse…
3132f59 
…l and an accordion. Fixes #42
kul3r4 added a commit that referenced this issue Mar 24, 2016
@kul3r4
An example which uses different amp video components inside a carouse…
32453a5 
…l and an accordion. Fixes #42
kul3r4 added a commit that referenced this issue Mar 24, 2016
@kul3r4
An example which uses different amp video components inside a carouse…
7585bde 
…l and an accordion. Fixes #42
kul3r4 added a commit that referenced this issue Mar 24, 2016
@kul3r4
An example which uses different amp video components inside a carouse…
3cce382 
…l and an accordion. Fixes #42
kul3r4 added a commit that referenced this issue Apr 26, 2016
@kul3r4
An example which uses different amp video components inside a carouse…
9835b3a 
…l and an accordion. Fixes #42
kul3r4 added a commit that referenced this issue Apr 26, 2016
@kul3r4
An example which uses different amp video components inside a carousel.
ed4b560 
Fixes #42
kul3r4 added a commit that referenced this issue Apr 26, 2016
@kul3r4
An example which uses different amp video components inside a carousel.
e39fa0b 
Fixes #42
kul3r4 added a commit that referenced this issue Apr 26, 2016
@kul3r4
An example which uses different amp video components inside a carousel.
258e82c 
Fixes #42
kul3r4 added a commit that referenced this issue Apr 27, 2016
@kul3r4
An example which uses different amp video components inside a carousel.
4b258e2 
Fixes #42
kul3r4 added a commit that referenced this issue Apr 27, 2016
@kul3r4
An example which uses different amp video components inside a carousel.
d457dec 
Fixes #42
kul3r4 added a commit that referenced this issue Apr 29, 2016
@kul3r4
An example which uses different amp video components inside a carousel.
2b9c232 
Fixes #42
kul3r4 added a commit that referenced this issue Apr 29, 2016
@kul3r4
An example which uses different amp video components inside a carousel.
bd0f183 
Fixes #42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kul3r4 kul3r4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adewale @kul3r4