Regenerate validator specs and update SpecGenerator and Dumper classes #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
approved these changes
Oct 18, 2021
schlessera
deleted the
update/spec-generator-printer-and-dumper-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a dependency to the PR #374 which will support
#[\ReturnTypeWillChange]attribute when execute in PHP 8.1 environment. Since there are lot of changes and most of them are not related to PHP 8.1, therefore I've created this separate PR.There are some new attributes added in
AmpProject\Attributeforamp-story-panning-media. You can find the new attribute list in this documentation.Additionally, I've update the
nette/php-generatorversion in the generator error message and using a fixed version 3.6.1. This is because, from 3.6.2 they refactor the Printer class and removed the $namespace param from printParameters method.