Issue #841: Return an array() inside the conditional.

As Weston mentioned, the DocBlock indicates an array(). So return an empty array instead of void.
ampproject · Feb 15, 2018 · 1b07e90 · 1b07e90
1 parent d3cc386
commit 1b07e90
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/includes/embeds/class-amp-playlist-embed-handler.php b/includes/embeds/class-amp-playlist-embed-handler.php
@@ -230,7 +230,7 @@ public function video_playlist() {
 	 */
 	public function get_thumb_dimensions( $track ) {
 		if ( ! isset( $track['thumb']['width'], $track['thumb']['height'] ) ) {
-			return;
+			return array();
 		}
 		$original_width  = intval( $track['thumb']['width'] );
 		$original_height = intval( $track['thumb']['height'] );

diff --git a/tests/test-class-amp-playlist-embed-handler.php b/tests/test-class-amp-playlist-embed-handler.php
@@ -176,6 +176,11 @@ public function test_get_thumb_dimensions() {
 			'thumb' => $dimensions,
 		);
 		$this->assertEquals( $expected_dimensions, $this->instance->get_thumb_dimensions( $track ) );
+
+		$track = array(
+			'thumb' => array(),
+		);
+		$this->assertEquals( array(), $this->instance->get_thumb_dimensions( $track ) );
 	}
 
 	/**