Add embed support for Twitter timelines via new amp-twitter attributes #1396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp-twitter
now supports arbitrary data attributes for Twitter timelines, based on a requireddata-timeline-source-type
attribute. All other arguments to pass along to the Twitter script must be provided as individual data attributes prefixed with "timeline-". As an example, if you setdata-timeline-source-type
to "profile", you also need to pass ascreenName
argument, which would need to happen viadata-timeline-screen-name
.This PR adds support for Twitter timelines, by automatically parsing embed URLs into appropriate
amp-twitter
elements. The code supportsprofile
,likes
andlist
source types.For reference: