-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of uniqid()
generated CSS class names in WP 5.9 breaks parsed CSS transient caching
#6925
Comments
@westonruter I've been playing around with your plugin and was wondering if we really need to override the Gutenberg/Core filters in order to convert the unique IDs. I've created this rough plugin that is a proof of concept for a different approach: It first hooks into the Next, it hooks into the
Do you think that with that plugin the CSS transient caching would be re-enabled? |
FYI: WordPress/gutenberg#38891 got labelled for backporting to a WP core minor release. |
The fix was released as part of Gutenberg 12.7. It's not yet merged into core. |
I didn't see your question. But yes, this would prevent CSS transient caching from being disabled. |
Followed the steps mentioned in this comment and found that the changes are reflecting in the markup but not on the Site health screen, with latest 2.2.2alpha Site health screen still shows transient caching is disabled
|
@dhaval-parekh please take a look at the issue reported in the QA notes |
Just saw the fix was merged into the WordPress 5.9 branch: WordPress/wordpress-develop@f4837d7 So it should be part of WordPress 5.9.3. |
I'm not able to reproduce this issue. Parsed CSS transient caching is getting re-enabled for me: unreproduced.mov |
Bug Description
See WordPress/gutenberg#38889 and the support forum topic.
I've created a mini plugin to fix the issue with layout container class names: https://gist.github.com/westonruter/71852bfeea22ebd7b570865a95b169d6
The same could be done for duotone and elements stylesheets as I've opened a PR to fix in Gutenberg: WordPress/gutenberg#38891 (disregarding the change to the responsive navigation block, which doesn't relate to CSS)
Note that the Duotone code is changing between WP 5.9 and 5.9.1, so two different versions may be needed.
We should probably apply these workarounds in 2.2.2 and potentially automatically re-enable CSS transient caching.
Expected Behaviour
Random strings should not be used to generate CSS class names so that parsed CSS transient caching is not automatically disabled.
Screenshots
No response
PHP Version
n/a
Plugin Version
2.2.1
AMP plugin template mode
Standard, Transitional, Reader
WordPress Version
5.9
Site Health
No response
Gutenberg Version
No response
OS(s) Affected
No response
Browser(s) Affected
No response
Device(s) Affected
No response
Acceptance Criteria
No response
Implementation Brief
No response
QA Testing Instructions
No response
Demo
No response
Changelog Entry
No response
The text was updated successfully, but these errors were encountered: