Ensure only remaining AMP scripts are printed when preparing response #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AMP scripts This is to guard against anything AMP-invalid from being output since remaining scripts are printed after the sanitizer has finished
|
Looks Good, Works As Expected Hi @westonruter, I also saw the issue of W3 Total Cache outputting that But with this PR applied, that script doesn't appear. And as expected, the component scripts still appear, like https://cdn.ampproject.org/v0/amp-bind-latest.js
|
This was referenced Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug exposed when testing the plugin with W3 Total Cache. That plugin prints out a script at the
wp_print_scriptsaction which is triggered when callingwp_print_scripts(). We can avoid this duplication of script printing by directly callingwp_scripts()->do_items()instead ofwp_print_scripts()which is essentially a wrapper for the former. The being printed here are the AMP component scripts that were discovered during the sanitization process. As such these scripts are run after sanitization has been completed, thus it is important that only the remaining AMP scripts be output here. The changes here ensure this.