Fix Plugin Conflict with Give plugin (previously created 500 server error when viewing site admin)

[KZeni]

Fixes #1720.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[KZeni]

@googlebot I've signed it!

[googlebot]

CLAs look good, thanks!

[ravinderk]

@KZeni I found that this function is a callback for the_title hook. In that can we need to update the following thing:

1. The second parameter for the_title filter in int type, so set default value to 0: https://core.trac.wordpress.org/browser/tags/5.0/src/wp-includes/post-template.php#L158
2. According to point 1, you can also update $post param value type to int instead of WP_Post in function description comment block.
3. Use trinary condition $post = empty( $post ) ? get_post() : $post

[westonruter]

I found we can simply further. Since $post is only used by get_post_type(), and since this function takes null|int|WP_Post as its type, then we just have to provide an empty default value for $post.

[westonruter]

Thank you very much for the PR and identifying the problem in the first place.

Please try my alternative patch included here. It will also fix the build error reported by Travis: https://travis-ci.org/ampproject/amp-wp/jobs/466619023#L186

[westonruter]

I suggest the following change instead:

- public static function filter_the_title_in_post_list_table( $title, $post ) {
+ public static function filter_the_title_in_post_list_table( $title, $post = null ) {

[westonruter]

See also #1723.

[westonruter]

I'm rebasing this PR against the 1.0 branch so we can merge it straight into the release branch.

[westonruter]

@KZeni could you please double check that the PR fixes the problem as it stands at the moment?

[KZeni]

@westonruter I can confirm that the PR as it stands (

- public static function filter_the_title_in_post_list_table( $title, $post ) {
+ public static function filter_the_title_in_post_list_table( $title, $post = null ) {

) is working on my end with both AMP and Give enabled on the site & viewing the site admin.