Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validating sanitizer with context for why element/attribute is invalid #3780

Merged
merged 41 commits into from
Dec 12, 2019
Merged

Improve validating sanitizer with context for why element/attribute is invalid #3780

merged 41 commits into from
Dec 12, 2019

Commits on Nov 26, 2019

  1. Eliminate premature/redundant attribute checks from validate_attr_spe… 

    …c_list_for_node
    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    bf28199 View commit details
    Browse the repository at this point in the history

  2. Remove redundant is_missing_mandatory_attribute check

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    656ebb0 View commit details
    Browse the repository at this point in the history

  3. Consolidate removal of elements without mandatory attributes

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    a7f2750 View commit details
    Browse the repository at this point in the history

  4. Introduce illegal_cdata error code

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    6475b70 View commit details
    Browse the repository at this point in the history

  5. Fix return value docs for validate_attr_spec_list_for_node

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    ad440fa View commit details
    Browse the repository at this point in the history

  6. Reuse check_attr_spec_rule_mandatory in is_missing_mandatory_attribute

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    3f2f50e View commit details
    Browse the repository at this point in the history

  7. Introduce specific error codes for attribute value violations

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    3bb3d8e View commit details
    Browse the repository at this point in the history

  8. Include list of missing mandatory attributes in validation error

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    ad66b8f View commit details
    Browse the repository at this point in the history

  9. Extract AMP validator error codes and messages from spec

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    35638c5 View commit details
    Browse the repository at this point in the history

  10. Use constant in switch statement

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    a2e20d6 View commit details
    Browse the repository at this point in the history

  11. Fix removing emptyable-attributes and fix is_missing_mandatory_attribute

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    ef80051 View commit details
    Browse the repository at this point in the history

  12. Add constants for error codes; improve CDATA error reporting

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    2d6ec3d View commit details
    Browse the repository at this point in the history

  13. Add fine-grained error codes for CDATA

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    00eb55c View commit details
    Browse the repository at this point in the history

  14. Revert "Extract AMP validator error codes and messages from spec" 

    This reverts commits 8ae5c3b and 0b30e4a.
    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    a6d0fc9 View commit details
    Browse the repository at this point in the history

  15. Fix validation of __amp_source_origin URL value

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    15fb6dd View commit details
    Browse the repository at this point in the history

  16. Eliminate duplicated testing; add code checking

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    c55c58c View commit details
    Browse the repository at this point in the history

  17. Add DISALLOWED_DESCENDANT_TAG error code

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    7f4bf4e View commit details
    Browse the repository at this point in the history

  18. Fix checking of empty URL before relative URL

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    df96667 View commit details
    Browse the repository at this point in the history

  19. Add assertions for specific error codes

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    7b32198 View commit details
    Browse the repository at this point in the history

  20. Move erroneous sanitiation inside of validate_tag_spec_for_node method

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    9808761 View commit details
    Browse the repository at this point in the history

  21. Add fine-grained error codes for elements that have bad ancestors or … 

    …descendants
    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    374e0d3 View commit details
    Browse the repository at this point in the history

  22. Add constants for normalized error codes used in style sanitizer

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    934bbd1 View commit details
    Browse the repository at this point in the history

  23. Ensure body present instead of raising error

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    5da07dc View commit details
    Browse the repository at this point in the history

  24. Improve error codes used in media converters; add error context data

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    b0dfd17 View commit details
    Browse the repository at this point in the history

  25. Include spec_name in validation error

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    2c42a07 View commit details
    Browse the repository at this point in the history

  26. Include spec_name in validation errors raised by style sanitizer

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    10b0c29 View commit details
    Browse the repository at this point in the history

  27. Verify unique tag spec names when generating spec

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    6975bd0 View commit details
    Browse the repository at this point in the history

  28. Remove redundant info from validation error now that spec_name provided

    @westonruter
    westonruter committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    e2db927 View commit details
    Browse the repository at this point in the history

  29. Fix up PHP comments 

    Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
    @westonruter @schlessera
    westonruter and schlessera committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    5e56cce View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2019

  1. Remove obsolete DISALLOWED_DOMAIN checks

    @westonruter
    westonruter committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    9067d6c View commit details
    Browse the repository at this point in the history

  2. Add tests for INVALID_CDATA_CONTENTS and DISALLOWED_RELATIVE_URL

    @westonruter
    westonruter committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    5d9c205 View commit details
    Browse the repository at this point in the history

  3. Add test for MANDATORY_CDATA_MISSING_OR_INCORRECT

    @westonruter
    westonruter committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    7470a24 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2019

  1. Add tests for MANDATORY_TAG_ANCESTOR, DISALLOWED_TAG_ANCESTOR, and (n… 

    …ew) DISALLOWED_TAG_MULTIPLE_CHOICES
    @westonruter
    westonruter committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    038caa7 View commit details
    Browse the repository at this point in the history

  2. Add test for INCORRECT_NUM_CHILD_TAGS

    @westonruter
    westonruter committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    998c45c View commit details
    Browse the repository at this point in the history

  3. Remove redundant validation error data; test for non-redundant data

    @westonruter
    westonruter committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    22b1869 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2019

  1. Merge branch 'develop' of github.com:ampproject/amp-wp into add/inval… 

    …id-markup-reason

* 'develop' of github.com:ampproject/amp-wp:
  Pull the built `block-libray` package from Gutenberg SVN if it does not exists (#3847)
  Update dependency @babel/plugin-transform-react-jsx to v7.7.4 (#3688)
  Update dependency @babel/plugin-proposal-class-properties to v7… (#3687)
  Update dependency @babel/cli to v7.7.4 (#3685)
  Update dependency browserslist to v4.7.3 (#3792)
  Update dependency postcss to v7.0.23 (#3791)
  Update dependency autoprefixer to v9.7.2 (#3679)
  For the Gallery block, use the recommended amp-lightbox-gallery
    @westonruter
    westonruter committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    8550fd7 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Bring sanity to the code

    @schlessera
    schlessera committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    322035b View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. Merge branch 'develop' of github.com:ampproject/amp-wp into add/inval… 

    …id-markup-reason

* 'develop' of github.com:ampproject/amp-wp: (143 commits)
  Update dependency @wordpress/block-editor to v3.3.0 (#3691)
  Update dependency @wordpress/editor to v9.8.0 (#3693)
  Update dependency @wordpress/compose to v3.8.0 (#3736)
  Use comment as array key for data set to show when failure happens
  Remove unused AMP_YouTube_Embed_Handler::sanitize_v_arg method after 7a97571
  Bump stylesheet cache group after #3866 (#3880)
  Delete AMP_YouTube_Embed_Handler::shortcode() and oembed()
  Delete AMP_Twitter_Embed_Handler::oembed()
  Prevent wrapping plugin names in code tags
  Update dependency @wordpress/blocks to v6.8.0 (#3734)
  Update dependency @wordpress/core-data to v2.8.0 (#3737)
  Update dependency @wordpress/edit-post to v3.9.0 (#3692)
  Update dependency @wordpress/components to v8.4.0 (#3735)
  Update dependency @wordpress/element to v2.9.0 (#3741)
  Align @param descriptions in test_video_override
  Replace a call to ->shortcode() with the logic from shortcode()
  Refactor AMP_Vimeo_Embed_Handler::shortcode() into video_override()
  Deprecate AMP_YouTube_Embed_Handler::shortcode()
  Restore AMP_YouTube_Embed_Handler::video_override()
  Improve theme inline CSS checks
  ...
    @westonruter
    westonruter committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    dc76b9f View commit details
    Browse the repository at this point in the history

  2. Fix typos in comments and code style 

    Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
    @westonruter @schlessera
    westonruter and schlessera committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    b96e4e7 View commit details
    Browse the repository at this point in the history

  3. Harmonize logic for getting stylesheet by URL 

    Remove STYLESHEET_INVALID_FILE_PATH code and always fall-back to HTTP request when file not on file system
    @westonruter
    westonruter committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    827659a View commit details
    Browse the repository at this point in the history

  4. Use SORT_REGULAR flag for array_unique() instead of serializing array… 

    …s as strings

Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
    @westonruter @schlessera
    westonruter and schlessera committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    f7d00f9 View commit details
    Browse the repository at this point in the history