Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stylesheet cache group after change to bundle common font files for externalizing data: URLs #3880

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

westonruter
Copy link
Member

Summary

I was getting some strange inconsistent validation results for excessive CSS problems, and I found out it was due to having cached CSS without the fix applied to externalize the font URLs, as was done in #3866. This PR bumps the version number to prevent others from experiencing the same.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v1.4.2 milestone Dec 4, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Dec 4, 2019
@westonruter westonruter merged commit 531c263 into develop Dec 5, 2019
@westonruter westonruter deleted the update/stylesheet-cache-group branch December 5, 2019 23:49
westonruter added a commit that referenced this pull request Dec 5, 2019
westonruter added a commit that referenced this pull request Dec 6, 2019
…id-markup-reason

* 'develop' of github.com:ampproject/amp-wp: (143 commits)
  Update dependency @wordpress/block-editor to v3.3.0 (#3691)
  Update dependency @wordpress/editor to v9.8.0 (#3693)
  Update dependency @wordpress/compose to v3.8.0 (#3736)
  Use comment as array key for data set to show when failure happens
  Remove unused AMP_YouTube_Embed_Handler::sanitize_v_arg method after 7a97571
  Bump stylesheet cache group after #3866 (#3880)
  Delete AMP_YouTube_Embed_Handler::shortcode() and oembed()
  Delete AMP_Twitter_Embed_Handler::oembed()
  Prevent wrapping plugin names in code tags
  Update dependency @wordpress/blocks to v6.8.0 (#3734)
  Update dependency @wordpress/core-data to v2.8.0 (#3737)
  Update dependency @wordpress/edit-post to v3.9.0 (#3692)
  Update dependency @wordpress/components to v8.4.0 (#3735)
  Update dependency @wordpress/element to v2.9.0 (#3741)
  Align @param descriptions in test_video_override
  Replace a call to ->shortcode() with the logic from shortcode()
  Refactor AMP_Vimeo_Embed_Handler::shortcode() into video_override()
  Deprecate AMP_YouTube_Embed_Handler::shortcode()
  Restore AMP_YouTube_Embed_Handler::video_override()
  Improve theme inline CSS checks
  ...
westonruter added a commit that referenced this pull request Dec 19, 2019
* tag '1.4.2': (25 commits)
  Bump 1.4.2
  Bump 'tested up to' to 5.3.2
  Catch unfiltered requests when testing Crowsignal embed (#3956)
  Bump version 1.4.2-RC1
  Bump 'Tested up to' to 5.3.1
  Remove test case for paired browsing since broken in WP4.9 and would not pass in AMP 1.4 (#3928)
  Further refine is_exclusively_dependent and add tests (#3928)
  Only include hoverintent-js in dev mode if exclusive dependency of admin-bar (#3928)
  Include admin-bar script deps in dev mode (e.g. hoverintent-js) (#3928)
  Fix tests after security fix in WP 5.3.1 (r46896) (#3926)
  Add E2E tests to allow_failures
  Convert `theme_features` variable into `get_theme_config` function
  Only apply smooth scroll fix on 'Twenty Twenty' <= 1.0.0
  Re-add smooth scrolling fix on WP < 5.3.1
  No need to apply smooth scrolling fix for Twenty Twenty theme
  Bump stylesheet cache group after #3866 (#3880)
  Return allowed KSES tags if not an array (#3879)
  Bundle common font files for externalizing data: URLs (#3866)
  Pull the built `block-libray` package from Gutenberg SVN if it does not exists (#3847)
  Optimize is_amp_allowed_attribute checking for reference points (#3815)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants