Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to prevent storing parsed CSS in transients #4177

Merged
merged 33 commits into from
Mar 23, 2020
Merged

Add ability to prevent storing parsed CSS in transients #4177

merged 33 commits into from
Mar 23, 2020

Commits on Mar 19, 2020

  1. Add filter to prevent storing parsed CSS in transients

    @westonruter @schlessera
    westonruter authored and schlessera committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    ece53ed View commit details
    Browse the repository at this point in the history

  2. Rename use_cache to use_object_cache

    @schlessera
    schlessera committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    217cc4b View commit details
    Browse the repository at this point in the history

  3. Add infrastructure for managing background tasks

    @schlessera
    schlessera committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    4d2bdba View commit details
    Browse the repository at this point in the history

  4. Add logic to monitor CSS caching and disable if needed

    @schlessera
    schlessera committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    2accca5 View commit details
    Browse the repository at this point in the history

  5. Make use of AMP Options Manager and skip transients as needed

    @schlessera
    schlessera committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    a622435 View commit details
    Browse the repository at this point in the history

  6. Add tests

    @schlessera
    schlessera committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    6600b16 View commit details
    Browse the repository at this point in the history

  7. Use assertInternalType instead of assertIsInt for PHPUnit back-compat

    @westonruter
    westonruter committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    164dac2 View commit details
    Browse the repository at this point in the history

  8. Fix test_amp_get_content_sanitizers for added allow_transient_caching

    @westonruter
    westonruter committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    d28a5ef View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Document filters

    @schlessera
    schlessera committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    2b08f22 View commit details
    Browse the repository at this point in the history

  2. Refactor and simplify cron handling

    @schlessera
    schlessera committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    d7e506f View commit details
    Browse the repository at this point in the history

  3. Add srteamlined way of adding services, with activation and deactivation

    @schlessera
    schlessera committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    ba094e1 View commit details
    Browse the repository at this point in the history

  4. Add Site Health integration

    @schlessera
    schlessera committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    61e358e View commit details
    Browse the repository at this point in the history

  5. Turn maybe_instantiate() into instances() and return those 

    Co-Authored-By: Weston Ruter <westonruter@google.com>
    @schlessera @westonruter
    schlessera and westonruter committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    10665d6 View commit details
    Browse the repository at this point in the history

  6. Short-circuit monitoring when an object cache is being used 

    Co-Authored-By: Weston Ruter <westonruter@google.com>
    @schlessera @westonruter
    schlessera and westonruter committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    b34eadf View commit details
    Browse the repository at this point in the history

  7. Add todo for multisite blog iteration on (de)activation hooks

    @schlessera
    schlessera committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    a7646b2 View commit details
    Browse the repository at this point in the history

  8. Pass $network_wide through (de)activation chain

    @schlessera
    schlessera committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    08506c2 View commit details
    Browse the repository at this point in the history

  9. Iterate over sites for unscheduling on deactivation

    @schlessera
    schlessera committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    39e1d39 View commit details
    Browse the repository at this point in the history

  10. Schedule events on admin_init

    @schlessera
    schlessera committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    8210c98 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2020

  1. Use get_sites() instead of a direct SQL query

    @schlessera
    schlessera committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    d229af9 View commit details
    Browse the repository at this point in the history

  2. Check against a capability, not a role

    @schlessera
    schlessera committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    6542b7e View commit details
    Browse the repository at this point in the history

  3. Add warnings to network plugins screen

    @schlessera
    schlessera committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    eaf8259 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into add/disabling-parsed-css-transient-caching

    @schlessera
    schlessera committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    83d8a8d View commit details
    Browse the repository at this point in the history

  5. Fix Test_Monitor_CSS_Transient_Caching 

    * Ensure that external object cache is disabled during tests.
* Replace removed use of activate() method with call to schedule_event().
* Pass required attribute to deactivate() method.
    @westonruter
    westonruter committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    0362ea4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' of github.com:ampproject/amp-wp into add/disab… 

    …ling-parsed-css-transient-caching

* 'develop' of github.com:ampproject/amp-wp:
  Fix passing of numbers to _n()
  Prevent case where validation error can be raised on already-removed node
  Fix MISSING_URL checks by inferring ALLOW_EMPTY from MANDATORY
  Tighten up validation error titles
  Remove markup from translations
  Make phpcs happy
  Remove DISALLOWED_TAG_MULTIPLE_CHOICES validation error code
  Replace quotes with code tags
  Make phpcs happy
  Add error titles for internal error codes
  Add error titles for error codes found in AMP specification
  Revert "Generate PHP class with error codes from AMP specification"
  Generate PHP class with error codes from AMP specification
    @westonruter
    westonruter committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    2683dce View commit details
    Browse the repository at this point in the history

  7. Remove unused use statements

    @westonruter
    westonruter committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    43affb0 View commit details
    Browse the repository at this point in the history

  8. Ensure warning icon uses color emoji and warning can be translated

    @westonruter
    westonruter committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    27b3039 View commit details
    Browse the repository at this point in the history

  9. Split boolean state for transient caching to be tri-state indicating … 

    …ext object cache
    @westonruter
    westonruter committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    7dd5c78 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2020

  1. Fix calling non-static method non-statically

    @westonruter
    westonruter committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    9ad9b10 View commit details
    Browse the repository at this point in the history

  2. Use non-static method invocations 

    Co-Authored-By: Pierre Gordon <16200219+pierlon@users.noreply.github.com>
    @westonruter @pierlon
    westonruter and pierlon committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    a0995ff View commit details
    Browse the repository at this point in the history

  3. Add linting to ensure amp.php is compatibility with PHP 5.2

    @westonruter
    westonruter committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    7d3163f View commit details
    Browse the repository at this point in the history

  4. Make amp.php compatibility with PHP 5.2 

    * Move functions to amp-helper-functions.php.
* Add amp_bootstrap_plugin() function to contain former top-level calls
    @westonruter
    westonruter committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    686edc7 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Revert using __DIR__ in bootstrap file 

    Co-Authored-By: Weston Ruter <westonruter@google.com>
    @schlessera @westonruter
    schlessera and westonruter committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    80d1bf3 View commit details
    Browse the repository at this point in the history

  2. Remove unused constant

    @schlessera
    schlessera committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    e53a3da View commit details
    Browse the repository at this point in the history