Increase default Jest timeout to 30s #5901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierlon
added
Testing
Codecov Report
@@ Coverage Diff @@
## develop #5901 +/- ##
=============================================
- Coverage 75.16% 75.12% -0.04%
- Complexity 5665 5667 +2
=============================================
Files 210 210
Lines 17019 17023 +4
=============================================
- Hits 12792 12789 -3
- Misses 4227 4234 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Plugin builds for 1097e87 are ready 🛎️!
|
westonruter
approved these changes
Feb 19, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The E2E test
Template mode recommendations with non-reader-theme active › makes correct recommendations when user is not technical and the current theme is not a reader themehas become flaky as it now sometimes times out while attempting to install thehestiatheme.To resolve this, this PR increases the default Jest timeout from 10s to 30s. Alternatively, the 30s timeout could be applied specifically to the aforementioned test, but that may also have to be done for similar tests that sometimes have long timeouts (like the ones that
awaiton installing themes and plugins, for example).Example of flaky test: https://github.com/ampproject/amp-wp/runs/1930306642#step:12:17