Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-base-carousel snap-by looks broken #4270

Closed
dvoytenko opened this issue Aug 3, 2020 · 1 comment · Fixed by ampproject/amphtml#32817
Closed

amp-base-carousel snap-by looks broken #4270

dvoytenko opened this issue Aug 3, 2020 · 1 comment · Fixed by ampproject/amphtml#32817
Assignees
@CrystalOnScript
Labels
Category: Content P3: Low Type: Bug
Projects
Content

Comments

@dvoytenko
Copy link
Contributor

image

Seems like something should be there after ". This ..."
@matthiasrohmer matthiasrohmer added this to To do in Content via automation Aug 4, 2020
@caroqliu
Copy link
Collaborator

From ampproject/amphtml#20595:

For example, snap-align="2" means that the carousel will snap on every other slide. This is primarily useful when used with the visible-count attribute.

@patrickkettner patrickkettner mentioned this issue Feb 23, 2021
Merged
Content automation moved this from To do to Done Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CrystalOnScript CrystalOnScript

Labels
Category: Content P3: Low Type: Bug
Projects
Content
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove stray "That" ampproject/amphtml
4 participants
@dvoytenko @caroqliu @matthiasrohmer @CrystalOnScript