Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stray "That" #32817

Merged
merged 1 commit into from Feb 23, 2021
Merged

remove stray "That" #32817

merged 1 commit into from Feb 23, 2021

Conversation

patrickkettner
Copy link
Contributor

typo in the docs, fixes ampproject/amp.dev#4270

@patrickkettner patrickkettner merged commit b0b29cf into master Feb 23, 2021
@caroqliu
Copy link
Contributor

FYI the rest of the sentence was:

This is primarily useful when used with the visible-count attribute.

Not sure how valuable this is to include, could be helpful clarification.

@patrickkettner
Copy link
Contributor Author

Sorry, I saw your comment but the strings weren't a 1-to-1 and I misunderstood your meaning, the "useful with visable-count" bit is already in the sentence that isn't cut off, was there something missing?

@caroqliu
Copy link
Contributor

Good point, all good!

caroqliu pushed a commit to caroqliu/amphtml that referenced this pull request Feb 23, 2021
@rsimha rsimha deleted the fix-snap-by-typo branch March 1, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amp-base-carousel snap-by looks broken
4 participants