-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🍱 Update dimensions for new assets #2030
Conversation
Looks good though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please use consistent naming scheme for the images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few name suggestions. The image files are still very large. We should get the images <40kb. For example, the default squoosh settings already gives good results.
Thanks!
pages/shared/data/tools.yaml
Outdated
src: https://media.tick.co/images/web/create.jpg | ||
width: 1000 | ||
height: 581 | ||
src: /static/img/tools/create.jpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename to: amp-story-tick.jpg
pages/shared/data/tools.yaml
Outdated
src: /static/img/tools/insights.png | ||
width: 1000 | ||
height: 550 | ||
src: /static/img/tools/insights.jpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename to amp-insights.jpg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect - thanks!
No description provided.