Skip to content

Commit

Permalink
build-system: cleanup esbuild options (#37468)
Browse files Browse the repository at this point in the history
  • Loading branch information
samouri committed Feb 3, 2022
1 parent 2907543 commit 035071a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
3 changes: 0 additions & 3 deletions build-system/tasks/extension-helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -678,9 +678,6 @@ async function maybeBuildBentoExtensionJs(dir, name, options) {
const bentoName = getBentoName(name);
return buildExtensionJs(dir, bentoName, {
...options,
// Use esbuild since Closure does not use a different babel config for
// Bento elements.
esbuild: true,
wrapper: 'bento',
babelCaller: options.minify
? 'bento-element-minified'
Expand Down
7 changes: 1 addition & 6 deletions build-system/tasks/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,7 @@ async function compileBentoRuntime(options) {
const filename = `${srcDir}/${srcFilename}`;
const fileSource = generateBentoRuntimeEntrypoint();
await fs.outputFile(filename, fileSource);
await doBuildJs(jsBundles, 'bento.js', {
...options,
// The pre-closure babel step wants the entry file to be generated earlier.
// Much simpler to generate it here and use esbuild instead.
esbuild: true,
});
await doBuildJs(jsBundles, 'bento.js', options);
}

/**
Expand Down

0 comments on commit 035071a

Please sign in to comment.