🐛 Add subid support to TrafficStars Ad (#37107)

* Add subid support to trafficstars ad * Remove exess subid atrribute from trafficstars ad * Fix trafficstars ad docs
ampproject · Dec 6, 2021 · 0457155 · 0457155
1 parent 4df29d5
commit 0457155
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/ads/vendors/trafficstars.js b/ads/vendors/trafficstars.js
@@ -2,13 +2,23 @@ import {loadScript, validateData} from '#3p/3p';
 import {parseJson} from '#core/types/object/json';
 
 const requiredParams = ['spot'];
-const jsonParams = ['nativeSettings', 'wrapperStyles', 'iFrameStyles'];
+const jsonParams = [
+  'nativeSettings',
+  'wrapperStyles',
+  'iFrameStyles',
+  'queriesParams',
+];
 const params = [
   'uploadLink',
-  'queriesParams',
   'onLoadResponseHook',
   'onSpotRenderedHook',
   'onLoadErrorHook',
+  'subid',
+  'subid_1',
+  'subid_2',
+  'subid_3',
+  'subid_4',
+  'subid_5',
 ];
 const optionalParams = params.concat(jsonParams);
 const adContainerId = 'trafficstars_id';

diff --git a/ads/vendors/trafficstars.md b/ads/vendors/trafficstars.md
@@ -18,6 +18,12 @@ Serves ads from the [TrafficStars](https://www.trafficstars.com/).
   data-on-load-response-hook="{(data: TMasterSpotData) => void}"
   data-on-spot-rendered-hook="{(element: HTMLElement) => void}"
   data-on-load-error-hook="{() => void}"
+  data-subid="{string}"
+  data-subid_1="{string}"
+  data-subid_2="{string}"
+  data-subid_3="{string}"
+  data-subid_4="{string}"
+  data-subid_5="{string}"
 >
 </amp-embed>
 ```
@@ -40,3 +46,9 @@ For details on the configuration semantics, please contact the ad network or ref
 -   `onLoadResponseHook` - hook after ad request success
 -   `onSpotRenderedHook` - hook after ad render success
 -   `onLoadErrorHook` - hook after ad request error
+-   `subid` - attribute of data
+-   `subid_1` - attribute of data
+-   `subid_2` - attribute of data
+-   `subid_3` - attribute of data
+-   `subid_4` - attribute of data
+-   `subid_5` - attribute of data