Uses don't need to be on this

ampproject · Apr 23, 2018 · 06912c3 · 06912c3
1 parent 9361753
commit 06912c3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/build-system/eslint-rules/unused-private-field.js b/build-system/eslint-rules/unused-private-field.js
@@ -34,10 +34,10 @@ module.exports = function(context) {
   }
 
 
-  function shouldCheckMember(node) {
+  function shouldCheckMember(node, needsThis = true) {
     const {computed, object, property} = node;
     if (computed ||
-        object.type !== 'ThisExpression' ||
+        (needsThis && object.type !== 'ThisExpression') ||
         property.type !== 'Identifier') {
       return false;
     }
@@ -116,7 +116,7 @@ module.exports = function(context) {
 
     'ClassBody MemberExpression': function(node) {
       if (shouldIgnoreFile() ||
-         !shouldCheckMember(node) ||
+         !shouldCheckMember(node, false) ||
          isAssignment(node)) {
         return;
       }