Skip to content

Commit

Permalink
Add instructions to the legacy bundle size failure message (#20012)
Browse files Browse the repository at this point in the history
  • Loading branch information
danielrozenberg committed Dec 20, 2018
1 parent 9b883b8 commit 09de023
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion build-system/tasks/bundle-size.js
Expand Up @@ -277,7 +277,17 @@ async function legacyBundleSizeCheck() {
cyan(maxSize), red('(Δ +') + cyan(sizeDelta) + red('KB)'));
log(red('This is part of a new effort to reduce AMP\'s binary size ' +
'(#14392).'));
log(red('Please contact @choumx or @jridgewell for assistance.'));
log(green('How to proceed from here:'), 'send a pull request to edit',
'the', cyan('bundle-size/.max_size'), 'file in the',
cyan('ampproject/amphtml-build-artifacts'), 'repository.');
log('Increases to the max size should be in', cyan('0.1KB'),
'intervals');
log('Direct link to edit this file and create a pull request:',
cyan('https://github.com/ampproject/amphtml-build-artifacts/edit/' +
'master/bundle-size/.max_size'));
log('Tag @choumx and @jridgewell in the PR description for approval.');
log(yellow('Note: this process is being replaced by a GitHub' +
'Application check, instead of running on Travis.'));
process.exitCode = 1;
return;
case STATUS_PASS:
Expand Down

0 comments on commit 09de023

Please sign in to comment.