Skip to content

Commit

Permalink
Skip new test failures after Chrome93 release
Browse files Browse the repository at this point in the history
  • Loading branch information
samouri committed Sep 1, 2021
1 parent 72c7936 commit 0fcba3b
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ describes.sandboxed('iframe-transport-client', {}, (env) => {
window./*OK*/ postMessage(payload, '*');
}

it('fails to create iframeTransportClient if no window.name ', () => {
// TODO:(35898): unskip
it.skip('fails to create iframeTransportClient if no window.name ', () => {
const oldWindowName = window.name;
expect(() => {
window.name = '';
Expand Down
3 changes: 2 additions & 1 deletion extensions/amp-pan-zoom/0.1/test/test-amp-pan-zoom.js
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ describes.realWin(
});
});

it('should correctly update bounds with bottom-aligned content', () => {
// TODO(): unskip.
it.skip('should correctly update bounds with bottom-aligned content', () => {
return getPanZoom({
'style': 'justify-content: start; flex-direction: column-reverse',
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ describes.fakeWin(
}
);

describes.realWin(
// TODO(35898): unskip
describes.realWin.skip(
'HighlightHandler',
{
// We can not overwrite win.location with realWin.
Expand Down
3 changes: 2 additions & 1 deletion test/unit/test-amp-context.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,10 @@ describes.sandboxed('3p ampcontext.js', {}, (env) => {
});
});

// TODO(35898): unskip
it.configure()
.skipFirefox()
.run('should throw error if metadata missing', () => {
.skip('should throw error if metadata missing', () => {
win.name = generateIncorrectAttributes();
const platform = new Platform(window);
expect(() => new AmpContext(win)).to.throw(
Expand Down

0 comments on commit 0fcba3b

Please sign in to comment.