Using enum.

ampproject · Jan 12, 2019 · 17f31d2 · 17f31d2
1 parent 3c5a3bc
commit 17f31d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/extensions/amp-story/1.0/amp-story-page-attachment.js b/extensions/amp-story/1.0/amp-story-page-attachment.js
@@ -19,6 +19,7 @@ import {
   StateProperty,
   getStoreService,
 } from './amp-story-store-service';
+import {HistoryStates} from './amp-story';
 import {Layout} from '../../../src/layout';
 import {closest} from '../../../src/dom';
 import {dev} from '../../../src/log';
@@ -369,7 +370,7 @@ export class AmpStoryPageAttachment extends AMP.BaseElement {
 
     setHistoryState(
         this.win,
-        'ampStoryAttachmentPageId',
+        HistoryStates.ATTACHMENT_PAGE_ID,
         /** @type {string} */
         (this.storeService_.get(StateProperty.CURRENT_PAGE_ID)));
   }
@@ -397,6 +398,6 @@ export class AmpStoryPageAttachment extends AMP.BaseElement {
           () => toggle(dev().assertElement(this.containerEl_), false), 250);
     });
 
-    setHistoryState(this.win, 'ampStoryAttachmentPageId', null);
+    setHistoryState(this.win, HistoryStates.ATTACHMENT_PAGE_ID, null);
   }
 }
diff --git a/extensions/amp-story/1.0/amp-story.js b/extensions/amp-story/1.0/amp-story.js
@@ -149,7 +149,7 @@ const Attributes = {
 };
 
 /** @enum {string} */
-const HistoryStates = {
+export const HistoryStates = {
   ATTACHMENT_PAGE_ID: 'ampStoryAttachmentPageId',
   BOOKEND_ACTIVE: 'ampStoryBookendActive',
   PAGE_ID: 'ampStoryPageId',