Skip to content

Commit

Permalink
Disable all e2e tests that became flaky on Docker
Browse files Browse the repository at this point in the history
  • Loading branch information
danielrozenberg committed Jul 15, 2021
1 parent 374eadd commit 1f995d3
Show file tree
Hide file tree
Showing 7 changed files with 26 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ describes.endtoend(
//TODO(sparhami): fails on shadow demo
it.configure()
.skipShadowDemo()
.run('should snap on the center point', async () => {
// TODO(#35241): flaky test disabled in #35176
.skip('should snap on the center point', async () => {
const el = await getScrollingElement(controller);
const slides = await getSlides(controller);
const scrollAmount = 1 + slideOneWidth / 2;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ describes.endtoend(
controller = env.controller;
});

it('should set snap property on spacers', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('should set snap property on spacers', async () => {
const spacers = await getSpacers(controller);
for (let i = 0; i < spacers.length; i++) {
const spacer = spacers[i];
Expand Down
12 changes: 8 additions & 4 deletions extensions/amp-base-carousel/1.0/test-e2e/test-responsive.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ describes.endtoend(
await controller.switchToShadowRoot(carousel);
});

it('should layout correctly initially', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('should layout correctly initially', async () => {
const firstSlide = await getSlide(styles, controller, 0);

// 3 slides width width 1000 = 333 width per slide.
Expand All @@ -54,7 +55,8 @@ describes.endtoend(
});
});

it('should layout correctly after resize', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('should layout correctly after resize', async () => {
const firstSlide = await getSlide(styles, controller, 0);

await controller.setWindowRect({
Expand All @@ -68,7 +70,8 @@ describes.endtoend(
});
});

it('should retain position when changing the visible count', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('should retain position when changing the visible count', async () => {
const el = await getScrollingElement(styles, controller);
const secondSlide = await getSlide(styles, controller, 1);

Expand All @@ -85,7 +88,8 @@ describes.endtoend(
await expect(controller.getElementRect(secondSlide)).to.include({x: 0});
});

it('should respond to attribute changes', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('should respond to attribute changes', async () => {
const firstSlide = await getSlide(styles, controller, 0);

// 3 slides width width 1000 = 333 width per slide.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ describes.endtoend(
controller = env.controller;
});

it('should open with both arrows', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('should open with both arrows', async () => {
// Click on image 2
const secondImage = await controller.findElement('#second');
await controller.click(secondImage);
Expand All @@ -62,7 +63,8 @@ describes.endtoend(
).to.equal('false');
});

it('should open with one arrow', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('should open with one arrow', async () => {
// Click on last image
const lastImage = await controller.findElement('#fourth');
await controller.click(lastImage);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ describes.endtoend(
});

describe('rendering', () => {
it('renders the default social share button', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('renders the default social share button', async () => {
const host = await controller.findElement('#one');

await controller.switchToShadowRoot(host);
Expand All @@ -57,7 +58,8 @@ describes.endtoend(
).to.not.equal(0);
});

it('renders the social share button with custom sizing', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('renders the social share button with custom sizing', async () => {
const host = await controller.findElement('#three');

await controller.switchToShadowRoot(host);
Expand All @@ -71,7 +73,8 @@ describes.endtoend(
).to.equal(400);
});

it('renders the social share button with custom type and endpoint', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('renders the social share button with custom type and endpoint', async () => {
const host = await controller.findElement('#four');

await controller.switchToShadowRoot(host);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ describes.endtoend(
controller = env.controller;
});

it('should render correctly', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('should render correctly', async () => {
await clickThroughPages(controller, /* numPages */ 7);
const activePage = await controller.findElement('[active]');
await expect(controller.getElementAttribute(activePage, 'ad')).to.exist;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ describes.endtoend(
controller = env.controller;
});

it('should render correctly', async () => {
// TODO(#35241): flaky test disabled in #35176
it.skip('should render correctly', async () => {
await clickThroughPages(controller, /* numPages */ 7);
const activePage = await controller.findElement('[active]');
await expect(controller.getElementAttribute(activePage, 'ad')).to.exist;
Expand Down

0 comments on commit 1f995d3

Please sign in to comment.