amp-instagram: allow changeHeight unconditionally (#11788)

ampproject · Jan 25, 2018 · 2270d9e · 2270d9e
1 parent 0819d2e
commit 2270d9e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/extensions/amp-instagram/0.1/amp-instagram.js b/extensions/amp-instagram/0.1/amp-instagram.js
@@ -210,8 +210,7 @@ class AmpInstagram extends AMP.BaseElement {
         if (this.iframe_ && this.iframe_./*OK*/offsetHeight !== height) {
           // Height returned by Instagram includes header, so
           // subtract 48px top padding
-          this.attemptChangeHeight(height - (PADDING_TOP + PADDING_BOTTOM))
-              .catch(() => {});
+          this./*OK*/changeHeight(height - (PADDING_TOP + PADDING_BOTTOM));
         }
       });
     }

diff --git a/extensions/amp-instagram/0.1/test/test-amp-instagram.js b/extensions/amp-instagram/0.1/test/test-amp-instagram.js
@@ -161,7 +161,7 @@ describes.realWin('amp-instagram', {
     return getIns('fBwFP', true).then(ins => {
       const impl = ins.implementation_;
       const iframe = ins.querySelector('iframe');
-      const attemptChangeHeight = sandbox.spy(impl, 'attemptChangeHeight');
+      const changeHeight = sandbox.spy(impl, 'changeHeight');
       const newHeight = 977;
 
       expect(iframe).to.not.be.null;
@@ -170,9 +170,9 @@ describes.realWin('amp-instagram', {
         height: newHeight,
       });
 
-      expect(attemptChangeHeight).to.be.calledOnce;
+      expect(changeHeight).to.be.calledOnce;
       // Height minus padding
-      expect(attemptChangeHeight.firstCall.args[0]).to.equal(newHeight - 64);
+      expect(changeHeight.firstCall.args[0]).to.equal(newHeight - 64);
     });
   });