🏗 Make visual tests depend on module build (#37673)

ampproject · Feb 14, 2022 · 2d2e54c · 2d2e54c
1 parent 5244199
commit 2d2e54c
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/build-system/pr-check/module-build.js b/build-system/pr-check/module-build.js
@@ -26,16 +26,19 @@ function pushBuildWorkflow() {
  * Steps to run during PR builds.
  */
 function prBuildWorkflow() {
-  // TODO(#31102): This list must eventually match the same buildTargets check
-  // found in pr-check/nomodule-build.js as we turn on the systems that
-  // run against the module build. (ex. visual diffs, e2e, etc.)
-  if (buildTargetsInclude(Targets.RUNTIME, Targets.INTEGRATION_TEST)) {
+  if (
+    buildTargetsInclude(
+      Targets.RUNTIME,
+      Targets.INTEGRATION_TEST,
+      Targets.VISUAL_DIFF
+    )
+  ) {
     timedExecOrDie('amp dist --esm --fortesting');
     storeModuleBuildToWorkspace();
   } else {
     skipDependentJobs(
       jobName,
-      'this PR does not affect the runtime or integration tests'
+      'this PR does not affect the runtime, integration tests, or visual diff tests'
     );
   }
 }