Add error message for unparseable checkConsentHref response (#29696)

* init * Try catch
ampproject · Sep 4, 2020 · 2ff4363 · 2ff4363
1 parent 63848d3
commit 2ff4363
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/extensions/amp-consent/0.1/amp-consent.js b/extensions/amp-consent/0.1/amp-consent.js
@@ -607,11 +607,19 @@ export class AmpConsent extends AMP.BaseElement {
         return ampdoc.whenFirstVisible().then(() => {
           return expandConsentEndpointUrl(this.element, resolvedHref).then(
             (expandedHref) => {
-              return xhrService
-                .fetchJson(expandedHref, init)
-                .then((res) =>
-                  xhrService.xssiJson(res, this.consentConfig_['xssiPrefix'])
-                );
+              return xhrService.fetchJson(expandedHref, init).then((res) => {
+                try {
+                  return xhrService.xssiJson(
+                    res,
+                    this.consentConfig_['xssiPrefix']
+                  );
+                } catch (e) {
+                  userAssert(
+                    false,
+                    'Could not parse the `checkConsentHref` response.'
+                  );
+                }
+              });
             }
           );
         });