Skip to content

Commit

Permalink
Fix page attachment dev document: 1) screenshots 2) layout (#36360)
Browse files Browse the repository at this point in the history
  • Loading branch information
ychsieh committed Oct 15, 2021
1 parent 21f4f26 commit 30be4d5
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions extensions/amp-story/amp-story-page-attachment.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ String that customizes the button text. The default is "Swipe up".
```html
<amp-story-page-attachment
layout="nodisplay"
cta-text="Call To Action">
cta-text="Explore Tasting Menu">
...
</amp-story-page-attachment>
```
Expand All @@ -96,6 +96,8 @@ String that customizes the button text. The default is "Swipe up".

String representing a URL pointing to an image. Optimize performance and avoid distortion by using a 48x48px image.

![amp-story-page-attachment-1-image](https://github.com/ampproject/amphtml/raw/main/extensions/amp-story/img/amp-story-page-attachment-1-image.jpg)

```html
<amp-story-page-attachment
layout="nodisplay"
Expand All @@ -104,12 +106,12 @@ String representing a URL pointing to an image. Optimize performance and avoid d
</amp-story-page-attachment>
```

![amp-story-page-attachment-1-image](https://github.com/ampproject/amphtml/raw/main/extensions/amp-story/img/amp-story-page-attachment-1-image.jpg)

### `cta-image-2` (optional)

String representing a URL pointing to an image. Two images will display when `cta-image` and `cta-image-2` are defined. Optimize performance and avoid distortion by using a 48x48px image.

![amp-story-page-attachment-2-images](https://github.com/ampproject/amphtml/raw/main/extensions/amp-story/img/amp-story-page-attachment-2-images.jpg)

```html
<amp-story-page-attachment
layout="nodisplay"
Expand All @@ -119,8 +121,6 @@ String representing a URL pointing to an image. Two images will display when `ct
</amp-story-page-attachment>
```

![amp-story-page-attachment-2-images](https://github.com/ampproject/amphtml/raw/main/extensions/amp-story/img/amp-story-page-attachment-2-images.jpg)

### `title` (optional)

String that displays in the attachment's header when scrolling beyond the height of the viewport.
Expand Down
Binary file modified extensions/amp-story/img/amp-story-page-attachment-1-image.jpg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified extensions/amp-story/img/amp-story-page-attachment-2-images.jpg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified extensions/amp-story/img/amp-story-page-attachment-cta-text.jpg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 30be4d5

Please sign in to comment.