Add hidden attribute to bento-lightbox and bento-sidebar to prevent F…

…OUC (#37070)
ampproject · Dec 6, 2021 · 32f415a · 32f415a
1 parent 80ca53e
commit 32f415a
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/extensions/amp-lightbox/1.0/README.md b/extensions/amp-lightbox/1.0/README.md
@@ -58,7 +58,7 @@ defineBentoLightbox();
     ></script>
   </head>
   <body>
-    <bento-lightbox id="my-lightbox">
+    <bento-lightbox id="my-lightbox" hidden>
       Lightboxed content
       <button id="close-button">Close lightbox</button>
     </bento-lightbox>
@@ -198,7 +198,7 @@ When the `scrollable` attribute is present, the content of the lightbox can scro
     ></script>
   </head>
   <body>
-    <bento-lightbox id="my-lightbox">
+    <bento-lightbox id="my-lightbox" hidden>
       Lightboxed content
       <button id="close-button">Close lightbox</button>
     </bento-lightbox>

diff --git a/extensions/amp-lightbox/1.0/example/index.html b/extensions/amp-lightbox/1.0/example/index.html
@@ -40,7 +40,7 @@
     </style>
   </head>
   <body>
-    <bento-lightbox id="my-lightbox">
+    <bento-lightbox id="my-lightbox" hidden>
       <div class="lightbox-content">
         <h1>Lightboxed content</h1>
         <button id="close-button">Close lightbox</button>

diff --git a/extensions/amp-sidebar/1.0/README.md b/extensions/amp-sidebar/1.0/README.md
@@ -58,7 +58,7 @@ defineBentoSidebar();
     />
   </head>
   <body>
-    <bento-sidebar id="sidebar1" side="right">
+    <bento-sidebar id="sidebar1" side="right" hidden>
       <ul>
         <li>Nav item 1</li>
         <li>Nav item 2</li>

diff --git a/extensions/amp-sidebar/1.0/example/index.html b/extensions/amp-sidebar/1.0/example/index.html
@@ -94,7 +94,7 @@
       </svg>
     </button>
 
-    <bento-sidebar id="sidebar1" side="left">
+    <bento-sidebar id="sidebar1" side="left" hidden>
       <button id="close-sidebar">
         <svg
           xmlns="http://www.w3.org/2000/svg"

diff --git a/test/fixtures/e2e/bento/lightbox.html b/test/fixtures/e2e/bento/lightbox.html
@@ -15,7 +15,7 @@
   <body>
     <button id="open-button">Open</button>
     <button id="close-button">Close</button>
-    <bento-lightbox id="my-lightbox">
+    <bento-lightbox id="my-lightbox" hidden>
       <p>Test</p>
       <button slot="close-button">Close</button>
     </bento-lightbox>