Skip to content

Commit

Permalink
🏗 Update closure compiler to February's version (#32525)
Browse files Browse the repository at this point in the history
  • Loading branch information
rsimha committed Feb 8, 2021
1 parent 703f113 commit 36a941b
Show file tree
Hide file tree
Showing 14 changed files with 39 additions and 53 deletions.
1 change: 0 additions & 1 deletion extensions/amp-playbuzz/0.1/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ export function debounce(func, wait, immediate) {
/**
*
* Gets an element creator using a given document to create elements.
* @export getElementCreator
* @param {Document} document
* @return {!Function}
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ const TAG = 'amp-user-notification';
const SERVICE_ID = 'userNotificationManager';

/**
* @export
* @typedef {{
* showNotification: boolean
* }}
Expand Down
49 changes: 30 additions & 19 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"devDependencies": {
"0x": "4.10.2",
"@ampproject/filesize": "4.2.0",
"@ampproject/google-closure-compiler": "20201207.0.0",
"@ampproject/google-closure-compiler": "20210202.0.0",
"@ampproject/remapping": "1.0.1",
"@babel/core": "7.12.13",
"@babel/eslint-parser": "7.12.13",
Expand Down
2 changes: 1 addition & 1 deletion src/impression.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const DEFAULT_APPEND_URL_PARAM = ['gclid', 'gclsrc'];
* (but somewhat more stringent) to the one described in the [3p/README.md](
* https://github.com/ampproject/amphtml/blob/master/3p/README.md)
*
* @export {!Array<!RegExp>}
* @type {!Array<!RegExp>}
*/
const TRUSTED_REFERRER_HOSTS = [
/**
Expand Down
2 changes: 0 additions & 2 deletions src/polyfills/fetch.js
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,6 @@ export class Response extends FetchResponse {

/**
* Installs fetch and Response polyfill
*
* @export
* @param {Window} win
*/
export function install(win) {
Expand Down
8 changes: 1 addition & 7 deletions src/polyfillstub/intersection-observer-stub.js
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ export class IntersectionObserverStub {
}

/**
* @export
* @return {?Element}
*/
get root() {
Expand All @@ -206,7 +205,6 @@ export class IntersectionObserverStub {
}

/**
* @export
* @return {*}
*/
get rootMargin() {
Expand All @@ -217,7 +215,6 @@ export class IntersectionObserverStub {
}

/**
* @export
* @return {*}
*/
get thresholds() {
Expand All @@ -228,7 +225,7 @@ export class IntersectionObserverStub {
}

/**
* @export
* @return {undefined}
*/
disconnect() {
if (this.inst_) {
Expand All @@ -239,7 +236,6 @@ export class IntersectionObserverStub {
}

/**
* @export
* @return {!Array}
*/
takeRecords() {
Expand All @@ -250,7 +246,6 @@ export class IntersectionObserverStub {
}

/**
* @export
* @param {!Element} target
*/
observe(target) {
Expand All @@ -264,7 +259,6 @@ export class IntersectionObserverStub {
}

/**
* @export
* @param {!Element} target
*/
unobserve(target) {
Expand Down
4 changes: 1 addition & 3 deletions src/polyfillstub/resize-observer-stub.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export class ResizeObserverStub {
}

/**
* @export
* @return {*}
*/
disconnect() {
if (this.inst_) {
Expand All @@ -131,7 +131,6 @@ export class ResizeObserverStub {
}

/**
* @export
* @param {!Element} target
*/
observe(target) {
Expand All @@ -145,7 +144,6 @@ export class ResizeObserverStub {
}

/**
* @export
* @param {!Element} target
*/
unobserve(target) {
Expand Down
1 change: 0 additions & 1 deletion src/runtime.js
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ function adoptShared(global, callback) {
* @param {function(string,?string=,number=)} unusedFn
* @param {function()=} opt_flush
* @deprecated
* @export
*/
global.AMP.setTickFunction = (unusedFn, opt_flush) => {};

Expand Down
4 changes: 2 additions & 2 deletions src/service/resource.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@ export class Resource {
/** @private {number} */
this.id_ = id;

/** @export @const {!AmpElement} */
/** @const {!AmpElement} */
this.element = element;

/** @export @const {string} */
/** @const {string} */
this.debugid = element.tagName.toLowerCase() + '#' + id;

/** @const {!Window} */
Expand Down
1 change: 0 additions & 1 deletion src/service/resources-interface.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ export class ResourcesInterface {
/**
* Returns a list of resources.
* @return {!Array<!./resource.Resource>}
* @export
*/
get() {}

Expand Down
3 changes: 0 additions & 3 deletions src/service/viewer-interface.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export class ViewerInterface {
* exported. Need to make sure it's not used externally.
* @param {string} name
* @return {?string}
* @export
*/
getParam(name) {}

Expand Down Expand Up @@ -168,7 +167,6 @@ export class ViewerInterface {
* @param {!JsonObject} data
* @param {boolean} unusedAwaitResponse
* @return {(!Promise<*>|undefined)}
* @export
*/
receiveMessage(eventType, data, unusedAwaitResponse) {}

Expand All @@ -177,7 +175,6 @@ export class ViewerInterface {
* messages to the viewer.
* @param {function(string, (?JsonObject|string|undefined), boolean):(!Promise<*>|undefined)} deliverer
* @param {string} origin
* @export
*/
setMessageDeliverer(deliverer, origin) {}

Expand Down
2 changes: 0 additions & 2 deletions src/style.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ let propertyNameCache;
const vendorPrefixes = ['Webkit', 'webkit', 'Moz', 'moz', 'ms', 'O', 'o'];

/**
* @export
* @param {string} camelCase camel cased string
* @return {string} title cased string
*/
Expand Down Expand Up @@ -55,7 +54,6 @@ function getVendorJsPropertyName_(style, titleCase) {
* Returns the possibly prefixed JavaScript property name of a style property
* (ex. WebkitTransitionDuration) given a camelCase'd version of the property
* (ex. transitionDuration).
* @export
* @param {!Object} style
* @param {string} camelCase the camel cased version of a css property name
* @param {boolean=} opt_bypassCache bypass the memoized cache of property
Expand Down
12 changes: 3 additions & 9 deletions third_party/subscriptions-project/swg.js
Original file line number Diff line number Diff line change
Expand Up @@ -2458,7 +2458,6 @@ const defaultStyles = {
};

/**
* @export
* @param {string} camelCase camel cased string
* @return {string} title cased string
*/
Expand Down Expand Up @@ -2488,7 +2487,6 @@ function getVendorJsPropertyName_(style, titleCase) {
* Returns the possibly prefixed JavaScript property name of a style property
* (ex. WebkitTransitionDuration) given a camelCase'd version of the property
* (ex. transitionDuration).
* @export
* @param {!Object} style
* @param {string} camelCase the camel cased version of a css property name
* @param {boolean=} bypassCache bypass the memoized cache of property
Expand Down Expand Up @@ -15090,7 +15088,7 @@ class PaymentsWebActivityDelegate {
*/
isVerticalCenterExperimentEnabled_(paymentDataRequest) {
return (
null
null
);
}

Expand Down Expand Up @@ -15276,7 +15274,7 @@ class UpiHandler {
loadPaymentData(paymentDataRequest, upiPaymentMethod, onResultCallback) {
const parameters = upiPaymentMethod['parameters'];
const transactionInfo = paymentDataRequest['transactionInfo'];
const supportedInstruments =
const supportedInstruments =
[{
'supportedMethods': ['https://tez.google.com/pay'],
'data': {
Expand Down Expand Up @@ -15720,7 +15718,6 @@ class PaymentsAsyncClient {
* @param {!IsReadyToPayRequest} isReadyToPayRequest
* @return {!Promise} The promise will contain the boolean result and error
* message when possible.
* @export
*/
isReadyToPay(isReadyToPayRequest) {
// Merge with paymentOptions, preferring values from isReadyToPayRequest
Expand Down Expand Up @@ -15888,7 +15885,6 @@ class PaymentsAsyncClient {
*
* @param {!PaymentDataRequest} paymentDataRequest Provides necessary
* information to support a payment.
* @export
*/
prefetchPaymentData(paymentDataRequest) {
/** @type {?string} */
Expand Down Expand Up @@ -15919,7 +15915,6 @@ class PaymentsAsyncClient {
*
* @param {!PaymentDataRequest} paymentDataRequest Provides necessary
* information to support a payment.
* @export
*/
loadPaymentData(paymentDataRequest) {
PayFrameHelper.postMessage({
Expand Down Expand Up @@ -15996,7 +15991,6 @@ class PaymentsAsyncClient {
*
* @param {!ButtonOptions=} options
* @return {!Element}
* @export
*/
createButton(options = {}) {
const button = null;
Expand Down Expand Up @@ -17287,7 +17281,7 @@ const REGWALL_HTML = `
font-size: 16px;
margin: 0 0 8px;
}

.gaa-metering-regwall--description {
color: #646464;
display: block;
Expand Down

0 comments on commit 36a941b

Please sign in to comment.