Skip to content

Commit

Permalink
Fix building HTML fixtures during integration tests (#32886)
Browse files Browse the repository at this point in the history
The `buildRuntime` (which is run unless you specify `--nobuild` flag) does a full build system cleaning, which also wipes out the built `test-bin` directory. We need to compile the HTML fixtures _after_ it, so they're not immediately cleaned.
  • Loading branch information
jridgewell committed Feb 25, 2021
1 parent 46f2dd0 commit 39d1d7f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions build-system/tasks/integration.js
Expand Up @@ -45,10 +45,11 @@ class Runner extends RuntimeTestRunner {

/** @override */
async maybeBuild() {
if (argv.nobuild) {
return;
if (!argv.nobuild) {
await buildRuntime();
}
await buildRuntime();
// buildRuntime will clean the directory! We have to do this afterwards.
await buildTransformedHtml();
}
}

Expand Down Expand Up @@ -85,7 +86,6 @@ async function integration() {
buildNewServer();
htmlTransform = require('../server/new-server/transforms/dist/transform')
.transform;
await buildTransformedHtml();

maybePrintArgvMessages();

Expand Down

0 comments on commit 39d1d7f

Please sign in to comment.