✨ Fast fetch implementation for Valueimpression network (#32061)

* Add new Valueimpression fast fetch implementation * Fix code style and copyright year * Edit build-system/test-configs/dep-check-config.js * Fix Travis CI error code style * Lint build-system/compile/bundles.config.extensions.json * Restore build-system/compile/bundles.config.extensions.json * Edit amp-ad-network-valueimpression-impl.js remove document.referrer * Edit build-system/test-configs/dep-check-config.js * Change rtc-config endpoint * Format code * revert wrong change build-system/compile/bundles.config.extensions.json * fix lint error * Update amp-ad-network-valueimpression-impl-internal.md
ampproject · Mar 4, 2021 · 3a6109b · 3a6109b
1 parent 8c2720a
commit 3a6109b
Show file tree

Hide file tree

Showing 10 changed files with 1,320 additions and 0 deletions.
diff --git a/ads/_a4a-config.js b/ads/_a4a-config.js
@@ -43,6 +43,7 @@ export function getA4ARegistry() {
       'doubleclick': () => true,
       'fake': () => true,
       'nws': () => true,
+      'valueimpression': () => true,
       // TODO: Add new ad network implementation "is enabled" functions here.
       // Note: if you add a function here that requires a new "import", above,
       // you'll probably also need to add an exception to

diff --git a/build-system/compile/bundles.config.extensions.json b/build-system/compile/bundles.config.extensions.json
@@ -56,6 +56,11 @@
     "latestVersion": "0.1"
   },
   {"name": "amp-ad-network-nws-impl", "version": "0.1", "latestVersion": "0.1"},
+  {
+    "name": "amp-ad-network-valueimpression-impl",
+    "version": "0.1",
+    "latestVersion": "0.1"
+  },
   {
     "name": "amp-addthis",
     "version": "0.1",

diff --git a/build-system/test-configs/dep-check-config.js b/build-system/test-configs/dep-check-config.js
@@ -197,6 +197,7 @@ exports.rules = [
       'extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js->extensions/amp-a4a/0.1/amp-a4a.js',
       'extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js->extensions/amp-a4a/0.1/amp-a4a.js',
       'extensions/amp-ad-network-oblivki-impl/0.1/amp-ad-network-oblivki-impl.js->extensions/amp-a4a/0.1/amp-a4a.js',
+      'extensions/amp-ad-network-valueimpression-impl/0.1/amp-ad-network-valueimpression-impl.js->extensions/amp-a4a/0.1/amp-a4a.js',
 
       // A4A impls importing amp fast fetch header name
       'extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js->extensions/amp-a4a/0.1/signature-verifier.js',
@@ -211,6 +212,7 @@ exports.rules = [
       'extensions/amp-ad-network-adzerk-impl/0.1/amp-ad-network-adzerk-impl.js->extensions/amp-a4a/0.1/amp-ad-template-helper.js',
       'extensions/amp-ad-network-adzerk-impl/0.1/amp-ad-network-adzerk-impl.js->extensions/amp-a4a/0.1/amp-ad-type-defs.js',
       'extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js->extensions/amp-a4a/0.1/refresh-manager.js',
+      'extensions/amp-ad-network-valueimpression-impl/0.1/amp-ad-network-valueimpression-impl.js->extensions/amp-a4a/0.1/refresh-manager.js',
 
       // AMP access depends on AMP access
       'extensions/amp-access-scroll/0.1/scroll-impl.js->extensions/amp-access/0.1/amp-access-client.js',
@@ -426,6 +428,7 @@ exports.rules = [
       // Ads remote config manager
       'extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js->src/service/real-time-config/callout-vendors.js',
       'extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js->src/service/real-time-config/real-time-config-impl.js',
+      'extensions/amp-ad-network-valueimpression-impl/0.1/amp-ad-network-valueimpression-impl.js->src/service/real-time-config/real-time-config-impl.js',
     ],
   },
   {

diff --git a/examples/valueimpression.amp.html b/examples/valueimpression.amp.html
@@ -0,0 +1,31 @@
+<!doctype html>
+<html ⚡>
+
+<head>
+  <meta charset="utf-8">
+  <title>Valueimpression Example</title>
+  <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1">
+  <style amp-custom>
+    amp-ad {
+      border: 1px solid #ccc;
+      max-width: 500px;
+    }
+
+  </style>
+  <script async custom-element="amp-ad" src="https://cdn.ampproject.org/v0/amp-ad-0.1.js"></script>
+  <script async src="https://cdn.ampproject.org/v0.js"></script>
+</head>
+
+<body>
+  <h2>Valueimpression Example</h2>
+  <div>
+    <amp-ad width="300" height="250" type="valueimpression" rtc-config='{
+        "urls": [
+            "https://useast.quantumdex.io/amp?client=23&metadata=autoCollect&tagid=1234"
+        ]
+      }'>
+    </amp-ad>
+  </div>
+</body>
+
+</html>