Resources: send a documentHeight message after ampInitialized if heig…

…ht has changed. (#28065) * Resources: Wait until ampInitialized to send documentHeight * switch to lower risk fix * revert piece * fix tests by adding vsync.measure() stub
ampproject · Apr 28, 2020 · 3c7b0b3 · 3c7b0b3
1 parent 50459f1
commit 3c7b0b3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/service/resources-impl.js b/src/service/resources-impl.js
@@ -647,6 +647,7 @@ export class ResourcesImpl {
   /** @override */
   ampInitComplete() {
     this.ampInitialized_ = true;
+    this.maybeChangeHeight_ = true;
     dev().fine(TAG_, 'ampInitComplete');
     this.schedulePass();
   }

diff --git a/test/unit/test-resources.js b/test/unit/test-resources.js
@@ -642,6 +642,7 @@ describes.realWin('Resources discoverWork', {amp: true}, (env) => {
     resources.resources_ = [resource1, resource2];
     resources.vsync_ = {
       mutate: (callback) => callback(),
+      measure: (callback) => callback(),
       measurePromise: (callback) => Promise.resolve(callback()),
     };
   });