Skip to content

Commit

Permalink
πŸ— Sync Chrome version used by Visual tests with Percy backend (#32774)
Browse files Browse the repository at this point in the history
  • Loading branch information
rsimha committed Feb 22, 2021
1 parent b546c3f commit 3d0c39b
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions build-system/tasks/visual-diff/index.js
Expand Up @@ -57,11 +57,18 @@ const percyCss = [
'.i-amphtml-new-loader * { animation: none !important; }',
].join('\n');

// Pin the version of Chromium to 78.0.3904.0, same as the one running on Percy.
// Use https://omahaproxy.appspot.com/ to convert version<->revision numbers.
// REPEATING TODO(@ampproject/wg-infra): keep this pinned with Percy whenever we
// update the version of Chrome in the project settings.
const PUPPETEER_CHROMIUM_REVISION = '693954';
// REPEATING TODO(@ampproject/wg-infra): Update this whenever the Percy backend
// starts using a new version of Chrome to render DOM snapshots.
//
// Steps:
// 1. Open a recent Percy build, and click the β€œβ“˜β€ icon
// 2. Note the Chrome major version at the bottom
// 3. Look up the full version at https://en.wikipedia.org/wiki/Google_Chrome_version_history
// 4. Open https://omahaproxy.appspot.com in a browser
// 5. Go to "Tools" -> "Version information"
// 6. Paste the full version in the "Version" field and click "Lookup"
// 7. Copy the value next to "Branch Base Position" and update the line below
const PUPPETEER_CHROMIUM_REVISION = '827102'; // 88.0.4324.0

const SNAPSHOT_SINGLE_BUILD_OPTIONS = {
widths: [375],
Expand Down

0 comments on commit 3d0c39b

Please sign in to comment.