review fixes

ampproject · Mar 2, 2021 · 3ecbd26 · 3ecbd26
1 parent 2783ddb
commit 3ecbd26
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/examples/a4a.amp.html b/examples/a4a.amp.html
@@ -67,7 +67,7 @@ <h2>A4A ad: doubleclick</h2>
     width="300">
   </amp-ad>
 
-  <h2>A4A ad: adsense</h2>
+  <h2>AdSense (may or may not be A4A)</h2>
   <amp-ad
     width="300"
     height="250"

diff --git a/extensions/amp-a4a/0.1/amp-a4a.js b/extensions/amp-a4a/0.1/amp-a4a.js
@@ -71,7 +71,6 @@ import {
 } from '../../../src/utils/intersection';
 import {isAdPositionAllowed} from '../../../src/ad-helper';
 import {isArray, isEnumValue, isObject} from '../../../src/types';
-
 import {listenOnce} from '../../../src/event-helper';
 import {
   observeWithSharedInOb,

diff --git a/extensions/amp-a4a/0.1/test/test-amp-a4a.js b/extensions/amp-a4a/0.1/test/test-amp-a4a.js
@@ -142,7 +142,9 @@ if (NO_SIGNING_RTV) {
     });
 
     it('should set the correct sandbox features', async () => {
-      env.sandbox.stub(Services.platformFor(env.win), 'isSafari').returns(false);
+      env.sandbox
+        .stub(Services.platformFor(env.win), 'isSafari')
+        .returns(false);
       await a4a.buildCallback();
       a4a.onLayoutMeasure();
       await a4a.layoutCallback();
@@ -183,7 +185,10 @@ if (NO_SIGNING_RTV) {
       await a4a.layoutCallback();
       const fie = doc.body.querySelector('iframe[srcdoc]');
       const violationSpy = env.sandbox.spy();
-      fie.contentWindow.addEventListener('securitypolicyviolation', violationSpy);
+      fie.contentWindow.addEventListener(
+        'securitypolicyviolation',
+        violationSpy
+      );
       const fakePolyfill = doc.createElement('script');
       fakePolyfill.src = 'https://cdn.ampproject.org/rtv/some-polyfill.js';
       fie.contentDocument.head.appendChild(fakePolyfill);
@@ -198,7 +203,10 @@ if (NO_SIGNING_RTV) {
       await a4a.layoutCallback();
       const fie = doc.body.querySelector('iframe[srcdoc]');
       const violationSpy = env.sandbox.spy();
-      fie.contentWindow.addEventListener('securitypolicyviolation', violationSpy);
+      fie.contentWindow.addEventListener(
+        'securitypolicyviolation',
+        violationSpy
+      );
       const fakePolyfill = doc.createElement('script');
       fakePolyfill.src = 'https://www.cats.example';
       fie.contentDocument.head.appendChild(fakePolyfill);
@@ -312,6 +320,7 @@ describes.realWin('amp-a4a', {amp: true}, (env) => {
   let getResourceStub;
 
   beforeEach(() => {
+    // TODO(ccordry): remove with no-signing launch or similar.
     env.sandbox.stub(AmpA4A.prototype, 'isInNoSigningExp').returns(false);
 
     fetchMock = null;