Embed mode url info (#35680)

* Hide Story URL info for embedMode=4.

* Impl code.

* embed-mode doc.

* Store service state.

extensions/amp-story/1.0/amp-story-store-service.js

@@ -94,6 +94,7 @@ export let InteractiveReactData;
  *    canShowPaginationButtons: boolean,
  *    canShowPreviousPageHelp: boolean,
  *    canShowSharingUis: boolean,
+ *    canShowStoryUrlInfo: boolean,
  *    canShowSystemLayerButtons: boolean,
  *    viewerCustomControls: !Array<!Object>,
  *    accessState: boolean,
@@ -144,6 +145,7 @@ export const StateProperty = {
   CAN_SHOW_PAGINATION_BUTTONS: 'canShowPaginationButtons',
   CAN_SHOW_PREVIOUS_PAGE_HELP: 'canShowPreviousPageHelp',
   CAN_SHOW_SHARING_UIS: 'canShowSharingUis',
+  CAN_SHOW_STORY_URL_INFO: 'canShowStoryUrlInfo',
   CAN_SHOW_SYSTEM_LAYER_BUTTONS: 'canShowSystemLayerButtons',
   VIEWER_CUSTOM_CONTROLS: 'viewerCustomControls',
 
@@ -590,6 +592,7 @@ export class AmpStoryStoreService {
       [StateProperty.CAN_SHOW_PREVIOUS_PAGE_HELP]: true,
       [StateProperty.CAN_SHOW_PAGINATION_BUTTONS]: true,
       [StateProperty.CAN_SHOW_SHARING_UIS]: true,
+      [StateProperty.CAN_SHOW_STORY_URL_INFO]: true,
       [StateProperty.CAN_SHOW_SYSTEM_LAYER_BUTTONS]: true,
       [StateProperty.VIEWER_CUSTOM_CONTROLS]: [],
       [StateProperty.ACCESS_STATE]: false,
@@ -671,6 +674,7 @@ export class AmpStoryStoreService {
         return {
           [StateProperty.CAN_SHOW_AUDIO_UI]: false,
           [StateProperty.CAN_SHOW_SHARING_UIS]: false,
+          [StateProperty.CAN_SHOW_STORY_URL_INFO]: false,
         };
       default:
         return {};

extensions/amp-story/1.0/amp-story-system-layer.js

@@ -462,7 +462,7 @@ export class SystemLayer {
       ? new AmpStoryViewerMessagingHandler(this.win_, this.viewer_)
       : null;
 
-    if (shouldShowStoryUrlInfo(this.viewer_)) {
+    if (shouldShowStoryUrlInfo(this.viewer_, this.storeService_)) {
       this.systemLayerEl_.classList.add('i-amphtml-embedded');
       this.getShadowRoot().setAttribute(HAS_INFO_BUTTON_ATTRIBUTE, '');
     } else {

extensions/amp-story/1.0/amp-story.js

@@ -1037,7 +1037,10 @@ export class AmpStory extends AMP.BaseElement {
         // Preloads and prerenders the share menu.
         this.shareMenu_.build();
 
-        const infoDialog = shouldShowStoryUrlInfo(devAssert(this.viewer_))
+        const infoDialog = shouldShowStoryUrlInfo(
+          devAssert(this.viewer_),
+          this.storeService_
+        )
           ? new InfoDialog(this.win, this.element)
           : null;
         if (infoDialog) {

extensions/amp-story/1.0/embed-mode.js

@@ -66,6 +66,7 @@ export const EmbedMode = {
    * This differs from the NOT_EMBEDDED embed mode in the following ways:
    * - Removes share icon from system layer
    * - Removes audio icon from system layer
+   * - Removes Story URL info from system layer
    */
   NO_SHARING_NOR_AUDIO_UI: 4,
 };

extensions/amp-story/1.0/test/test-utils.js

@@ -14,14 +14,15 @@
  * limitations under the License.
  */
 
+import {StateProperty} from '../amp-story-store-service';
 import {
   getRGBFromCssColorValue,
   getTextColorForRGB,
   shouldShowStoryUrlInfo,
   timeStrToMillis,
 } from '../utils';
 
-describes.fakeWin('amp-story utils', {}, () => {
+describes.fakeWin('amp-story utils', {}, (env) => {
   describe('timeStrToMillis', () => {
     it('should return millis for a milliseconds string', () => {
       const millis = timeStrToMillis('100ms');
@@ -109,31 +110,61 @@ describes.fakeWin('amp-story utils', {}, () => {
         getParam: () => null,
         isEmbedded: () => true,
       };
-      expect(shouldShowStoryUrlInfo(fakeViewer)).to.be.true;
+      const fakeStoreService = {get: () => true};
+      expect(shouldShowStoryUrlInfo(fakeViewer, fakeStoreService)).to.be.true;
     });
 
     it('should be forced to false when isEmbedded', () => {
       const fakeViewer = {
         getParam: () => '0',
         isEmbedded: () => true,
       };
-      expect(shouldShowStoryUrlInfo(fakeViewer)).to.be.false;
+      const fakeStoreService = {get: () => true};
+      expect(shouldShowStoryUrlInfo(fakeViewer, fakeStoreService)).to.be.false;
     });
 
     it('should be false when !isEmbedded', () => {
       const fakeViewer = {
         getParam: () => null,
         isEmbedded: () => false,
       };
-      expect(shouldShowStoryUrlInfo(fakeViewer)).to.be.false;
+      const fakeStoreService = {get: () => true};
+      expect(shouldShowStoryUrlInfo(fakeViewer, fakeStoreService)).to.be.false;
     });
 
     it('should be forced to true when !isEmbedded', () => {
       const fakeViewer = {
         getParam: () => '1',
         isEmbedded: () => false,
       };
-      expect(shouldShowStoryUrlInfo(fakeViewer)).to.be.true;
+      const fakeStoreService = {get: () => true};
+      expect(shouldShowStoryUrlInfo(fakeViewer, fakeStoreService)).to.be.true;
+    });
+
+    it('should be false when CAN_SHOW_STORY_URL_INFO is false', () => {
+      const fakeViewer = {
+        getParam: () => null,
+        isEmbedded: () => true,
+      };
+      const fakeStoreService = {get: () => {}};
+      const getStub = env.sandbox.stub(fakeStoreService, 'get').returns(false);
+      expect(shouldShowStoryUrlInfo(fakeViewer, fakeStoreService)).to.be.false;
+      expect(getStub).to.be.calledOnceWithExactly(
+        StateProperty.CAN_SHOW_STORY_URL_INFO
+      );
+    });
+
+    it('should be true when CAN_SHOW_STORY_URL_INFO is true', () => {
+      const fakeViewer = {
+        getParam: () => null,
+        isEmbedded: () => true,
+      };
+      const fakeStoreService = {get: () => {}};
+      const getStub = env.sandbox.stub(fakeStoreService, 'get').returns(true);
+      expect(shouldShowStoryUrlInfo(fakeViewer, fakeStoreService)).to.be.true;
+      expect(getStub).to.be.calledOnceWithExactly(
+        StateProperty.CAN_SHOW_STORY_URL_INFO
+      );
     });
   });
 });

extensions/amp-story/1.0/utils.js

@@ -15,6 +15,7 @@
  */
 
 import {Services} from '#service';
+import {StateProperty} from './amp-story-store-service';
 import {
   assertHttpsUrl,
   getSourceOrigin,
@@ -252,9 +253,13 @@ export function resolveImgSrc(win, url) {
 /**
  * Whether a Story should show the URL info dialog.
  * @param {!../../../src/service/viewer-interface.ViewerInterface} viewer
+ * @param {!./amp-story-store-service.AmpStoryStoreService} storeService
  * @return {boolean}
  */
-export function shouldShowStoryUrlInfo(viewer) {
+export function shouldShowStoryUrlInfo(viewer, storeService) {
+  if (!storeService.get(StateProperty.CAN_SHOW_STORY_URL_INFO)) {
+    return false;
+  }
   const showStoryUrlInfo = viewer.getParam('showStoryUrlInfo');
   return showStoryUrlInfo ? showStoryUrlInfo !== '0' : viewer.isEmbedded();
 }