Fixes to FIE test

ampproject · Apr 14, 2020 · 457130d · 457130d
1 parent b6ea443
commit 457130d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/extensions/amp-analytics/0.1/analytics-root.js b/extensions/amp-analytics/0.1/analytics-root.js
@@ -345,6 +345,11 @@ export class AnalyticsRoot {
    * @return {!Promise<!Array<!AmpElement>>} Array of AMP elements corresponding to the selector if found.
    */
   getAmpElements(context, selectors, selectionMethod) {
+    const x = isExperimentOn(
+      this.ampdoc.win,
+      'visibility-trigger-improvements'
+    );
+    console.log(this.ampdoc);
     if (
       isExperimentOn(this.ampdoc.win, 'visibility-trigger-improvements') &&
       isArray(selectors)

diff --git a/extensions/amp-analytics/0.1/test/test-analytics-root.js b/extensions/amp-analytics/0.1/test/test-analytics-root.js
@@ -726,7 +726,11 @@ describes.realWin(
     describe('get amp elements', () => {
       beforeEach(() => {
         child.classList.add('i-amphtml-element');
-        toggleExperiment(win, 'visibility-trigger-improvements', true);
+        toggleExperiment(
+          parentRoot.ampdoc.win,
+          'visibility-trigger-improvements',
+          true
+        );
       });
 
       afterEach(() => {
@@ -746,13 +750,14 @@ describes.realWin(
         child3.classList.add('notMyClass');
         child2.classList.add('i-amphtml-element');
         child3.classList.add('i-amphtml-element');
-        const e = await root.getAmpElements(body, ['.myClass'], null);
-
-        expect(e).to.deep.equals([child, child2]);
+        expect(
+          await root.getAmpElements(body, ['.myClass'], null)
+        ).to.deep.equals([child, child2]);
         // Check that non-experiment version works
-        // toggleExperiment(win, 'visibility-trigger-improvements', false);
-        // e = await root.getAmpElements(body, '.notMyClass', null);
-        // expect(e).to.deep.equals([child3]);
+        toggleExperiment(win, 'visibility-trigger-improvements', false);
+        expect(
+          await root.getAmpElements(body, '.notMyClass', null)
+        ).to.deep.equals([child3]);
       });
 
       it('should handle missing selector for AMP search', async () => {