Skip to content

Commit

Permalink
s/wg-analytics/wg-components (#35665)
Browse files Browse the repository at this point in the history
  • Loading branch information
samouri committed Aug 13, 2021
1 parent 88302b9 commit 4dc363d
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion build-system/tasks/bundle-size/APPROVERS.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"dist/v0/amp-analytics-?.?.?(m)js": {
"approvers": [
"ampproject/wg-analytics",
"ampproject/wg-components",
"ampproject/wg-performance"
],
"threshold": 0.1
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-analytics/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
rules: [
{
owners: [
{name: 'ampproject/wg-analytics'},
{name: 'ampproject/wg-components'},
{name: 'avimehta', requestReviews: false},
],
},
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-analytics/integrating-analytics.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Before you can add your analytics service to AMP HTML runtime, you may need to:

## Adding your configuration to the AMP HTML runtime

1. Create an [Intent-To-Implement issue](../../docs/contributing.md#contributing-features) stating that you'll be adding your analytics service's configuration to AMP HTML's runtime. Be sure to include **cc @ampproject/wg-analytics** in your description.
1. Create an [Intent-To-Implement issue](../../docs/contributing.md#contributing-features) stating that you'll be adding your analytics service's configuration to AMP HTML's runtime. Be sure to include **cc @ampproject/wg-components** in your description.
1. Develop a patch that implements the following:
1. A new configuration json file `${vendorName}.json` in the vendors [folder](https://github.com/ampproject/amphtml/tree/main/extensions/amp-analytics/0.1/vendors) including any options above and beyond the default, such as:
1. `"vars": {}` for additional default variables.
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-consent/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
owners: [
{name: 'ampproject/wg-ads-reviewers'},
{name: 'ampproject/wg-analytics'},
{name: 'ampproject/wg-components'},
],
},
],
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-crypto-polyfill/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
rules: [
{
owners: [{name: 'ampproject/wg-analytics'}],
owners: [{name: 'ampproject/wg-components'}],
},
],
}
2 changes: 1 addition & 1 deletion extensions/amp-experiment/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
rules: [
{
owners: [{name: 'ampproject/wg-analytics'}],
owners: [{name: 'ampproject/wg-components'}],
},
],
}
2 changes: 1 addition & 1 deletion extensions/amp-geo/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
rules: [
{
owners: [{name: 'ampproject/wg-analytics'}],
owners: [{name: 'ampproject/wg-components'}],
},
],
}
2 changes: 1 addition & 1 deletion src/service/url-expander/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
rules: [
{
owners: [{name: 'ampproject/wg-analytics'}],
owners: [{name: 'ampproject/wg-components'}],
},
],
}
2 changes: 1 addition & 1 deletion test/integration/test-amp-analytics.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {parseQueryString} from '#core/types/string/url';

import {BrowserController, RequestBank} from '#testing/test-helper';

// TODO(wg-analytics): These tests time out on Firefox and Safari.
// TODO(wg-components): These tests time out on Firefox and Safari.
describes.sandboxed
.configure()
.skipSafari()
Expand Down

0 comments on commit 4dc363d

Please sign in to comment.