lint local/camelcase: allow destructure (#36868)

* lint local/camelcase: allow destructure

* force rename

* Update build-system/eslint-rules/camelcase.js

Co-authored-by: Ryan Cebulko <ryan@cebulko.com>

* Update build-system/eslint-rules/camelcase.js

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

Co-authored-by: Ryan Cebulko <ryan@cebulko.com>
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

build-system/eslint-rules/camelcase.js

@@ -32,7 +32,7 @@ module.exports = function (context) {
       // Excuse membership access, unless we're in the LHS of an assignment.
       // This attempts to prevent us from defining new properties with underscores,
       // while allowing access to external objects that already have them.
-      // This mirros google-camelcase's logic.
+      // This mirrors google-camelcase's logic.
       const {parent} = node;
       if (parent.type === 'MemberExpression' && parent.property === node) {
         const grandParent = parent.parent;
@@ -46,6 +46,16 @@ module.exports = function (context) {
         }
       }
 
+      // Permit object destructuring, since that is similar to membership access.
+      // Requires that the key is immediately renamed to a conforming value.
+      if (
+        parent.type === 'Property' &&
+        parent.parent.type === 'ObjectPattern' &&
+        parent.key === node
+      ) {
+        return;
+      }
+
       context.report({
         node,
         message: `"${node.name}" must use camelCaseCapitalization.`,

src/compiler/compile.js

@@ -9,7 +9,6 @@ import {getBuilders} from './builders';
  * @return {import('./types').CompilerResponse}
  */
 export function compile(request) {
-  // eslint-disable-next-line local/camelcase
   const {component_versions: versions, document, nodes} = request ?? {};
   if (!versions || !(document || nodes)) {
     throw new Error(