add promise

ampproject · Apr 10, 2020 · 5067a21 · 5067a21
1 parent c48fe93
commit 5067a21
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/extensions/amp-consent/0.1/test-e2e/test-amp-consent-client-side.js b/extensions/amp-consent/0.1/test-e2e/test-amp-consent-client-side.js
@@ -39,7 +39,6 @@ describes.endtoend(
     it('should work with client side decision', async () => {
       resetAllElements();
       const currentUrl = await controller.getCurrentUrl();
-      //console.log('currentUrl is  ', currentUrl);
 
       // Verify no local storage decision
       await findElements(controller);
@@ -96,11 +95,11 @@ describes.endtoend(
         'postPromptUi': false,
       });
 
-      // Check the analytics request consentState
-      // const p = new Promise((resolve) => {
-      //   setTimeout(resolve, 1000);
-      // });
-      // await p;
+      // Check the analytics request consentState. Wait for 1 second for the
+      // request to arrive to avoid flaky test.
+      await new Promise((resolve) => {
+        setTimeout(resolve, 1000);
+      });
       await expect(
         'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking?consentState=sufficient'
       ).to.have.been.sent;

diff --git a/extensions/amp-consent/0.1/test-e2e/test-amp-consent-server-side.js b/extensions/amp-consent/0.1/test-e2e/test-amp-consent-server-side.js
@@ -36,7 +36,6 @@ describes.endtoend(
       controller = env.controller;
     });
 
-    //TODO (micajuineho): Unskip flaky test
     it('should respect server side decision and persist it', async () => {
       resetAllElements();
 
@@ -79,7 +78,11 @@ describes.endtoend(
         'postPromptUi': false,
       });
 
-      // Check the analytics request consentState
+      // Check the analytics request consentState. Wait for 1 second for the
+      // request to arrive to avoid flaky test.
+      await new Promise((resolve) => {
+        setTimeout(resolve, 1000);
+      });
       await expect(
         'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking?consentState=insufficient'
       ).to.have.been.sent;