Fix amp-position-observer not working in cross domain inabox. (#23982)

ampproject · Aug 22, 2019 · 5929c05 · 5929c05
1 parent b6a200f
commit 5929c05
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/examples/amphtml-ads/scrollbound-animation-ad.a4a.html b/examples/amphtml-ads/scrollbound-animation-ad.a4a.html
@@ -95,7 +95,6 @@
 <!--
 The animations are implemented using [amp-animation]({{g.doc('/content/amp-dev/documentation/components/reference/amp-animation.md', locale=doc.locale).url.path}}) which is an AMP component that uses [Web Animations API](https://www.w3.org/TR/web-animations/) to support both __time__ and __scroll__ based animations.
 -->
-<div style="height: 200vh"></div>
 <amp-animation id="adAnim" layout="nodisplay">
   <script type="application/json">
     {

diff --git a/src/inabox/inabox-viewport.js b/src/inabox/inabox-viewport.js
@@ -352,8 +352,8 @@ export class ViewportBindingInabox {
           MessageType.POSITION,
           data => {
             this.requestPositionPromise_ = null;
-            devAssert(data.targetRect, 'Host should send targetRect');
-            resolve(data.targetRect);
+            devAssert(data['targetRect'], 'Host should send targetRect');
+            resolve(data['targetRect']);
           }
         );
       });