Skip to content

Commit

Permalink
Support amp-facebook-comments, -like, and -page with one extens…
Browse files Browse the repository at this point in the history
…ion binary (`1.0` only) (#35064)

* Support all attrs in amp-facebook

* Move Storybook examples under amp-facebook

* Move to amp-facebook extension

* Move test files

* Remove dependency allowlist entries

* Update unit test

* Attempt adding validations

* Revert validator changes

* Remove extra line

* Add space
  • Loading branch information
caroqliu committed Jul 26, 2021
1 parent df315b6 commit 5a70c89
Show file tree
Hide file tree
Showing 22 changed files with 273 additions and 736 deletions.
26 changes: 0 additions & 26 deletions build-system/compile/bundles.config.extensions.json
Expand Up @@ -370,42 +370,16 @@
"version": "0.1",
"latestVersion": "0.1"
},
{
"name": "amp-facebook-comments",
"version": "1.0",
"latestVersion": "0.1",
"options": {
"wrapper": "bento"
}
},
{
"name": "amp-facebook-like",
"version": "0.1",
"latestVersion": "0.1"
},
{
"name": "amp-facebook-like",
"version": "1.0",
"latestVersion": "0.1",
"options": {
"hasCss": true,
"wrapper": "bento"
}
},
{
"name": "amp-facebook-page",
"version": "0.1",
"latestVersion": "0.1"
},
{
"name": "amp-facebook-page",
"version": "1.0",
"latestVersion": "0.1",
"options": {
"hasCss": true,
"wrapper": "bento"
}
},
{
"name": "amp-fit-text",
"version": "0.1",
Expand Down
6 changes: 0 additions & 6 deletions build-system/test-configs/dep-check-config.js
Expand Up @@ -256,12 +256,6 @@ exports.rules = [
'extensions/amp-facebook/1.0/amp-facebook.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-page/0.1/amp-facebook-page.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-comments/0.1/amp-facebook-comments.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-comments/1.0/amp-facebook-comments.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-comments/1.0/base-element.js->extensions/amp-facebook/1.0/facebook-base-element.js',
'extensions/amp-facebook-like/1.0/amp-facebook-like.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-like/1.0/base-element.js->extensions/amp-facebook/1.0/facebook-base-element.js',
'extensions/amp-facebook-page/1.0/amp-facebook-page.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-page/1.0/base-element.js->extensions/amp-facebook/1.0/facebook-base-element.js',

// VideoBaseElement, VideoIframe and VideoWrapper are meant to be shared.
'extensions/**->extensions/amp-video/1.0/video-base-element.js',
Expand Down
38 changes: 0 additions & 38 deletions extensions/amp-facebook-comments/1.0/amp-facebook-comments.css

This file was deleted.

74 changes: 0 additions & 74 deletions extensions/amp-facebook-comments/1.0/amp-facebook-comments.js

This file was deleted.

32 changes: 0 additions & 32 deletions extensions/amp-facebook-comments/1.0/base-element.js

This file was deleted.

64 changes: 0 additions & 64 deletions extensions/amp-facebook-comments/1.0/storybook/Basic.amp.js

This file was deleted.

38 changes: 0 additions & 38 deletions extensions/amp-facebook-like/1.0/amp-facebook-like.css

This file was deleted.

79 changes: 0 additions & 79 deletions extensions/amp-facebook-like/1.0/amp-facebook-like.js

This file was deleted.

0 comments on commit 5a70c89

Please sign in to comment.