Skip to content

Commit

Permalink
🚀 [Story performance] Move building share menu to share-menu.js (#37209)
Browse files Browse the repository at this point in the history
* Move building share menu to share-menu.js

* Reorganized share-menu.js

* Working share menu with proper split

* Fixed dep-check, streamlined build

* Fixed styling

* Cleaned up

* Updated comment

* CanonicalURL is unnecessary in constructor

* Fixed tests

* Removed outdated amp-story links

* Fixed lint errors
  • Loading branch information
mszylkowski committed Dec 20, 2021
1 parent 0f10e08 commit 6654c1a
Show file tree
Hide file tree
Showing 9 changed files with 504 additions and 613 deletions.
6 changes: 3 additions & 3 deletions build-system/test-configs/dep-check-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,11 +266,11 @@ exports.rules = [

// Story share menu
'extensions/amp-story-share-menu/0.1/amp-story-share-menu.js->extensions/amp-story/1.0/utils.js',
'extensions/amp-story-share-menu/0.1/amp-story-share-menu.js->extensions/amp-story/1.0/amp-story-share.js',
'extensions/amp-story-share-menu/0.1/amp-story-share-menu.js->extensions/amp-story/1.0/amp-story-store-service.js',
'extensions/amp-story-share-menu/0.1/amp-story-share-menu.js->extensions/amp-story/1.0/story-analytics.js',
'extensions/amp-story/1.0/amp-story.js->extensions/amp-story-share-menu/0.1/amp-story-share-menu.js',
'extensions/amp-story-share-menu/0.1/amp-story-share-menu.js->extensions/amp-story/1.0/amp-story-localization-service.js',
'extensions/amp-story-share-menu/0.1/amp-story-share-menu.js->extensions/amp-story/1.0/request-utils.js',
'extensions/amp-story-share-menu/0.1/amp-story-share-menu.js->extensions/amp-story/1.0/toast.js',
'extensions/amp-story/1.0/amp-story-share.js->extensions/amp-story-share-menu/0.1/amp-story-share-menu.js',

// Story Shopping
'extensions/amp-story-shopping/0.1/amp-story-shopping-config.js->extensions/amp-story/1.0/amp-story-store-service.js',
Expand Down

0 comments on commit 6654c1a

Please sign in to comment.