Skip to content

Commit

Permalink
πŸ— Replace all mentions of build cop with build on-duty (#33465)
Browse files Browse the repository at this point in the history
  • Loading branch information
rsimha committed Mar 24, 2021
1 parent b64e649 commit 674feac
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion contributing/DEVELOPING.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ We also recommend scanning the [spec](../spec/). The non-element part should hel

## Builds and releases

- The [AMP buildcop](buildcop.md) helps ensure that AMP's builds remain green (i.e. everything builds and all of the tests pass). If you run into issues with builds that seem unrelated to your changes see if the issue is present on [CircleCI](https://app.circleci.com/pipelines/github/ampproject/amphtml?branch=master) and send a message to the [#contributing](https://amphtml.slack.com/messages/C9HRJ1GPN) channel on Slack ([sign up for Slack](https://bit.ly/amp-slack-signup)).
- The [AMP Build On-duty](build-on-duty.md) helps ensure that AMP's builds remain green (i.e. everything builds and all of the tests pass). If you run into issues with builds that seem unrelated to your changes see if the issue is present on [CircleCI](https://app.circleci.com/pipelines/github/ampproject/amphtml?branch=master) and send a message to the [#contributing](https://amphtml.slack.com/messages/C9HRJ1GPN) channel on Slack ([sign up for Slack](https://bit.ly/amp-slack-signup)).
- Understanding the [AMP release process](release-schedule.md) is useful for understanding when a change in AMP will make it into production and what to do if things go wrong during the rollout of a change.

### Opting in to pre-release channels
Expand Down
12 changes: 6 additions & 6 deletions contributing/buildcop.md β†’ contributing/build-on-duty.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
# AMP Buildcop
# AMP Build On-Duty

The AMP buildcop is responsible for ensuring that the [master build](https://app.circleci.com/pipelines/github/ampproject/amphtml?branch=master) remains green. The AMP buildcop responsibility rotates between members of the community.
The AMP build on-duty is responsible for ensuring that the [master build](https://app.circleci.com/pipelines/github/ampproject/amphtml?branch=master) remains green. The AMP build on-duty responsibility rotates between members of the community.

Make sure you are a member of the [#contributing](https://amphtml.slack.com/messages/C9HRJ1GPN) channel on Slack while you are buildcop.
Make sure you are a member of the [#contributing](https://amphtml.slack.com/messages/C9HRJ1GPN) channel on Slack while you are build on-duty.

- If the build has been red for some time, please send a note to the #contributing channel if the issue is not already reported.
- Pay attention for reports of issues with the build that the community may send to this channel. (You may want to enable notifications for this channel while you are buildcop to make this easier.)
- Pay attention for reports of issues with the build that the community may send to this channel. (You may want to enable notifications for this channel while you are build on-duty to make this easier.)

## Buildcop Tasks
## Build On-Duty Tasks

1. Ensure the [master build](https://app.circleci.com/pipelines/github/ampproject/amphtml?branch=master) remains green. Your goal is to keep the build from being red for more than an hour.
1. Note that yellow builds are in the process of being created/tested so you do not need to do anything special with them.
2. Keep an eye out for emails sent to an address starting with amp-build-cop. **You are encouraged to set up a filter so that these emails will stand out to you.**
2. Keep an eye out for emails sent to an address starting with amp-build-on-duty. **You are encouraged to set up a filter so that these emails will stand out to you.**
3. You will need to investigate whether a red build is due to a flake or due to a real issue.
- If the issue is due to a flaky test:
- Create a ["Related to: Flaky Tests" issue](https://github.com/ampproject/amphtml/issues?q=is%3Aopen+is%3Aissue+label%3A%22Related+to%3A+Flaky+Tests%22). **Make sure to find an appropriate owner for the issue and assign it to them.**
Expand Down

0 comments on commit 674feac

Please sign in to comment.