pr comments

ampproject · Apr 25, 2017 · 68603c3 · 68603c3
1 parent 0e41eab
commit 68603c3
Showing 1 changed file with 23 additions and 19 deletions.
diff --git a/src/service/action-impl.js b/src/service/action-impl.js
@@ -199,26 +199,30 @@ export class ActionService {
   addChangeDetails_(event) {
     const detail = {};
     const target = event.target;
-    if (event.target.tagName.toLowerCase() === 'input') {
-      const inputType = target.getAttribute('type');
-      const fieldsToInclude = WHITELISTED_INPUT_DATA_[inputType];
-      if (fieldsToInclude) {
-        Object.keys(fieldsToInclude).forEach(field => {
-          const expectedType = fieldsToInclude[field];
-          const value = target[field];
-          if (expectedType === 'number') {
-            detail[field] = Number(value);
-          } else if (expectedType === 'boolean') {
-            detail[field] = !!value;
-          } else {
-            detail[field] = String(value);
-          }
-        });
+    const tagName = event.target.tagName.toLowerCase();
+    switch (tagName) {
+      case 'input':
+        const inputType = target.getAttribute('type');
+        const fieldsToInclude = WHITELISTED_INPUT_DATA_[inputType];
+        if (fieldsToInclude) {
+          Object.keys(fieldsToInclude).forEach(field => {
+            const expectedType = fieldsToInclude[field];
+            const value = target[field];
+            if (expectedType === 'number') {
+              detail[field] = Number(value);
+            } else if (expectedType === 'boolean') {
+              detail[field] = !!value;
+            } else {
+              detail[field] = String(value);
+            }
+          });
+          event.detail = detail;
+        }
+        break;
+      case 'select':
+        detail['value'] = target['value'];
         event.detail = detail;
-      }
-    } else if (event.target.tagName.toLowerCase() === 'select') {
-      detail['value'] = target['value'];
-      event.detail = detail;
+        break;
     }
   }