Skip to content

Commit

Permalink
Update CLA documentation (#30793)
Browse files Browse the repository at this point in the history
* Update CLA documentation

* Update contributing/contributing-code.md

Co-authored-by: Tobie Langel <tobie@unlockopen.com>

* Add alternative instructions for signing the CLA via email.

Co-authored-by: Tobie Langel <tobie@unlockopen.com>

* Remove sentence about email addresses

* Explicitly hyperlink the CLA URL so it works unambiguously

* Update contributing/contributing-code.md

Co-authored-by: Raghu Simha <rsimha@amp.dev>

Co-authored-by: Raghu Simha <rsimha@amp.dev>
Co-authored-by: Tobie Langel <tobie@unlockopen.com>
  • Loading branch information
3 people committed Oct 26, 2020
1 parent 038901e commit 68dfea1
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions contributing/contributing-code.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This document describes the process you will go through to make a change in AMP.

We want to make it as easy as possible to get in small fixes. A fix for a small bug should be as easy as creating a PR with the change, adding/fixing a test, and sending it to a reviewer.

- [ ] Sign the [Contributor License Agreement (CLA)](#contributor-license-agreement) as soon as possible if you haven't already done so. If you are contributing code on behalf of your company and your company is not yet covered by a CLA it can take a few days for the CLA to be verified.
- [ ] Agree to the [OpenJSF Contributor License Agreement (CLA)](#contributor-license-agreement).
- [ ] (optional) If you are fixing a bug and there is an existing GitHub issue, assign it to yourself (if you can) or comment on it to let others know you are working on it. If there is no GitHub issue consider filing one, but for minor fixes your PR description may be enough.
- [ ] (optional) [Find a guide](#find-a-guide) before you start coding to help you answer questions.
- [ ] Follow the parts of the [Implementation](#implementation) section that makes sense for your change. There are many parts of the process that you probably won't need to follow for a minor fix--e.g. you may not need to make validator changes or put your change behind an experiment for minor fixes. If in doubt ask your guide or the [#contributing channel](https://amphtml.slack.com/messages/C9HRJ1GPN/) on [Slack](https://bit.ly/amp-slack-signup).
Expand All @@ -31,7 +31,7 @@ Significant changes (e.g. new components or significant changes to behavior) req
**If you are deprecating/removing a feature, follow the [deprecation process](https://github.com/ampproject/amphtml/blob/master/spec/amp-versioning-policy.md#deprecations) instead of this process.**

- [ ] _Before you start coding_, [find a guide](#find-a-guide) who you can discuss your change with and who can help guide you through the process.
- [ ] Sign the [Contributor License Agreement (CLA)](#contributor-license-agreement) as soon as possible if you haven't already done so. If you are contributing code on behalf of your company and your company is not yet covered by a CLA it can take a few days for the CLA to be verified.
- [ ] Agree to the [OpenJSF Contributor License Agreement (CLA)](#contributor-license-agreement).
- [ ] File an [Intent-to-implement (I2I)](https://github.com/ampproject/amphtml/issues/new?assignees=&labels=INTENT+TO+IMPLEMENT&template=intent-to-implement--i2i-.md&title=I2I:%20%3Cyour%20change/update%3E) GitHub issue and cc your guide on it. The I2I should include:
- A description of the change you plan to implement.
- If you are integrating a third-party service, provide a link to the third-party's site and product.
Expand Down Expand Up @@ -94,7 +94,7 @@ Once you have found a guide, make sure to @-mention them on any issues / PRs rel
- [Includes validation rules and tests, if relevant](./building-an-amp-extension.md#allowing-proper-validations)
- [Provides an example, if relevant](./building-an-amp-extension.md#example-of-using-your-extension)
- Send your code for review.
- [Sign the Contributor License Agreement](#contributor-license-agreement) if you have not already done so.
- [Agree to the Contributor License Agreement](#contributor-license-agreement) if you have not already done so.
- [Pull the latest changes from the amphtml repo](./getting-started-e2e.md#pull-the-latest-changes-from-the-amphtml-repository) and resolve any conflicts.
- Run the **pre push** check, which is a tool that helps catch any issues before you submit your code. To enable the git pre-push hook, see [`enable-git-pre-push.sh`](../build-system/common/enable-git-pre-push.sh#L17-L20).
- [Push your changes](./getting-started-e2e.md#push-your-changes-to-your-github-fork)
Expand Down Expand Up @@ -123,17 +123,11 @@ For further detail on integrating third-party services (e.g., fonts, embeds, etc

## Contributor License Agreement

AMP requires all contributors to either sign an individual Contributor License Agreement or be covered by a corporate Contributor License Agreement in order to protect contributors and users in issues of intellectual property.
AMP requires all contributors to agree to the OpenJSF Contributor License Agreement in order to protect contributors and users in issues of intellectual property.

We recommend you handle signing/being covered by a CLA _before_ you send a PR to avoid problems, though this is not absolutely necessary until your code is ready to be merged in.
To agree to the OpenJSF Contributor License Agreement, visit [https://cla-assistant.io/ampproject/amphtml](https://cla-assistant.io/ampproject/amphtml), read through the agreement, and click "Sign in with GitHub to agree."

**Make sure that the email you associate with your CLA is the same email address you associate with your commits (likely via the `user.email` Git config as described on GitHub's [Set up Git](https://help.github.com/articles/set-up-git/) page).**

- **If you are contributing code on your own behalf** you can sign the [individual CLA](https://developers.google.com/open-source/cla/individual) instantly online.
- **If you are planning on contributing code on behalf of your company:**
- Your company will need to agree to a [corporate CLA](https://developers.google.com/open-source/cla/corporate) if it has not already done so. Although this is a relatively straightforward process, it requires approval from an authorized signer at your company and a manual verification process that may take a couple of days. To ensure you can get your code reviewed and merged quickly please start this process as soon as possible. The signer of your corporate CLA will associate a Google Group to the corporate CLA, and any email address added to this Google Group will be considered to be covered by this corporate CLA.
- To be covered by your company's corporate CLA the owner of the Google Group associated with the corporate CLA (someone at your company) will need to add your address to this Google Group.
- If you aren't sure whehther your company has already signed a corporate CLA, if you don't know who at your company owns the Google Group you need to be added to, or you run into any other questions about the corporate CLA, please reach out to @mrjoro (via cc on a PR or on [Slack](https://amphtml.slack.com) ([signup](https://bit.ly/amp-slack-signup))) or the [#contributing](https://amphtml.slack.com/messages/C9HRJ1GPN/details/) channel on Slack.
Alternatively, you also have the option of downloading the Contributor License Agreement from https://individual-cla.openjsf.org, filling it in, signing it, writing in your GitHub handle, and emailing it to operations@openjsf.org. As processing your CLA is done manually, this takes much longer and is therefore not recommended.

## Code review and approval

Expand Down

0 comments on commit 68dfea1

Please sign in to comment.