🏗 Build runtime for visual-diff only commits (#21002)

ampproject · Feb 22, 2019 · 6efcfc1 · 6efcfc1
1 parent 769ea6d
commit 6efcfc1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/build-system/pr-check/build.js b/build-system/pr-check/build.js
@@ -65,15 +65,16 @@ function main() {
         buildTargets.has('INTEGRATION_TEST') ||
         buildTargets.has('BUILD_SYSTEM') ||
         buildTargets.has('DEV_DASHBOARD') ||
-        buildTargets.has('FLAG_CONFIG')) {
+        buildTargets.has('FLAG_CONFIG') ||
+        buildTargets.has('VISUAL_DIFF')) {
 
       timedExecOrDie('gulp update-packages');
       timedExecOrDie('gulp build --fortesting');
       uploadBuildOutput(FILENAME);
     } else {
       console.log(`${FILELOGPREFIX} Skipping ` + colors.cyan('Build ') +
-          'because this commit does not affect the runtime, ' +
-          'build system, test files, or the dev dashboard');
+          'because this commit does not affect the runtime, build system, ' +
+          'test files, visual diff files, or the dev dashboard');
     }
   }
 

diff --git a/build-system/pr-check/dist-tests.js b/build-system/pr-check/dist-tests.js
@@ -38,6 +38,7 @@ const timedExecOrDie =
 
 function runSinglePassTest_() {
   timedExecOrDie('gulp clean');
+  timedExecOrDie('gulp update-packages');
   timedExecOrDie('gulp dist --fortesting --single_pass --psuedonames');
   timedExecOrDie('gulp test --integration ' +
       '--nobuild --compiled --single_pass --headless');
@@ -56,6 +57,7 @@ function main() {
     let ranTests = false;
 
     if (buildTargets.has('RUNTIME')) {
+      timedExecOrDie('gulp update-packages');
       timedExecOrDie('gulp dist --fortesting --noextensions');
       timedExecOrDie('gulp bundle-size --on_pr_build');
       ranTests = true;

diff --git a/build-system/pr-check/remote-tests.js b/build-system/pr-check/remote-tests.js
@@ -64,6 +64,7 @@ function main() {
       return 0;
     }
     downloadBuildOutput(FILENAME);
+    timedExecOrDie('gulp update-packages');
     startSauceConnect(FILENAME);
 
     if (buildTargets.has('RUNTIME') ||